Some fixes for object service #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1343 +/- ##
=======================================
Coverage 34.72% 34.72%
=======================================
Files 313 313
Lines 19536 19553 +17
=======================================
+ Hits 6783 6789 +6
- Misses 12215 12225 +10
- Partials 538 539 +1
Continue to review full report at Codecov.
|
carpawell
approved these changes
Apr 29, 2022
| @@ -89,6 +97,10 @@ func (b *BlobStor) PutRaw(addr *addressSDK.Address, data []byte, compress bool) | |||
| return new(PutRes), nil | |||
| } | |||
|
|
|||
| if compress { | |||
There was a problem hiding this comment.
is compressing small objects expected to stay that way?
There was a problem hiding this comment.
Yes, there are no problems here.
…tedTarget` Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
…and `remote` targets They work with prepared objects only. Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
cthulhu-rider
approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #1319 .