neofs-adm: add interactive configurator for storage node #1122
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1122 +/- ##
=======================================
Coverage 35.56% 35.56%
=======================================
Files 285 285
Lines 17936 17936
=======================================
Hits 6379 6379
Misses 11074 11074
Partials 483 483 Continue to review full report at Codecov.
|
| } | ||
|
|
||
| fatalOnErr(fmt.Errorf("can't create N3 client: %w", err)) | ||
| panic("unreachable") |
There was a problem hiding this comment.
We can return nil, though panic better communicates our intention.
There was a problem hiding this comment.
We can return
nil, thoughpanicbetter communicates our intention.
Yeah, but it looks like you fighting go compiler with this line. Maybe just this, then?
- fatalOnErr(fmt.Errorf("can't create N3 client: %w", err))
- panic("unreachable")
+ panic(fmt.Errorf("can't create N3 client: %w", err))There was a problem hiding this comment.
It would be strange to have a stack trace for this error, but not the others.
There was a problem hiding this comment.
Oh, I thought fatalOnErr produces panic, but it just prints to stderr and calls os.Exit(1).
| ) | ||
|
|
||
| var n3config = map[string]struct { | ||
| MorphRPC []string |
There was a problem hiding this comment.
Visibility of the fields varies for a reason?
| if len(s) == 0 { | ||
| return def | ||
| } | ||
| continue |
There was a problem hiding this comment.
Maybe it's worth to print what are we waiting for. Otherwise continue is redundant
There was a problem hiding this comment.
It is printed in readline.Line above, so the workflow is like this:
Use node as a relay? yes/[no]: kek
Use node as a relay? yes/[no]: please
Use node as a relay? yes/[no]: yes
...
| } | ||
|
|
||
| fatalOnErr(fmt.Errorf("can't create N3 client: %w", err)) | ||
| panic("unreachable") |
There was a problem hiding this comment.
Oh, I thought fatalOnErr produces panic, but it just prints to stderr and calls os.Exit(1).
…node Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
…igurator It also persists between sessions. Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
Close #1090 .
Signed-off-by: Evgenii Stratonikov evgeniy@nspcc.ru