-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/Reorganize object/acl
#1111
Refactor/Reorganize object/acl
#1111
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1111 +/- ##
==========================================
- Coverage 35.64% 35.52% -0.12%
==========================================
Files 284 288 +4
Lines 18055 18008 -47
==========================================
- Hits 6435 6397 -38
+ Misses 11129 11126 -3
+ Partials 491 485 -6
Continue to review full report at Codecov.
|
Make all operations that related to `neofs-api-go` library be placed in `v2` packages. They parse all v2-versioned structs info `neofs-sdk-go` abstractions and pass them to the corresponding `acl`/`eacl` packages. `v2` packages are the only packages that do import `neofs-api-go` library. `eacl` and `acl` provide public functions that only accepts `sdk` structures. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
`objectSDKAddress` -> `addressSDK`. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Make all operations that related to `neofs-api-go` library be placed in `v2` packages. They parse all v2-versioned structs info `neofs-sdk-go` abstractions and pass them to the corresponding `acl`/`eacl` packages. `v2` packages are the only packages that do import `neofs-api-go` library. `eacl` and `acl` provide public functions that only accepts `sdk` structures. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
`objectSDKAddress` -> `addressSDK`. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Make all operations that related to `neofs-api-go` library be placed in `v2` packages. They parse all v2-versioned structs info `neofs-sdk-go` abstractions and pass them to the corresponding `acl`/`eacl` packages. `v2` packages are the only packages that do import `neofs-api-go` library. `eacl` and `acl` provide public functions that only accepts `sdk` structures. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
`objectSDKAddress` -> `addressSDK`. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Alternative to #1095 solution of the #596.
Since it was decided to keep logic that works with requests in the repo (and not move it to
SDK
) it is impossible to removev2
package inobject/acl
service since something has to work with v2 requests anyway (implement interface in object pipeline in other words). So that PR reorganizes the structure of that directory to be similar to other packages inservice/object
: there arev2
packages inacl
andacl/eacl
dirs now. They parse all v2-versioned structs intoneofs-sdk-go
abstractions and pass them to the correspondingacl
/eacl
packages.v2
packages are the only packages that do importneofs-api-go
library.eacl
andacl
provide public functions that only acceptssdk
structures.Valid only after nspcc-dev/neofs-sdk-go#128 and rebasing.