Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1088] writecache: Fix small flushed mark #1088

Merged
merged 1 commit into from
Jan 19, 2022
Merged

[#1088] writecache: Fix small flushed mark #1088

merged 1 commit into from
Jan 19, 2022

Conversation

ZhangTao1596
Copy link
Contributor

Signed-off-by: ZhangTao1596 zhangtao@ngd.neo.org

@codecov
Copy link

codecov bot commented Jan 14, 2022 •
edited
Loading

Codecov Report

Merging #1088 (69a0145) into master (7c02a2e) will not change coverage.
The diff coverage is n/a.

❗ Current head 69a0145 differs from pull request most recent head e1a5e2c. Consider uploading reports for the commit e1a5e2c to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1088   +/-   ##
=======================================
  Coverage   36.86%   36.86%           
=======================================
  Files         268      268           
  Lines       15046    15046           
=======================================
  Hits         5547     5547           
  Misses       9038     9038           
  Partials      461      461

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c02a2e...e1a5e2c. Read the comment docs.

fyrchik
fyrchik reviewed Jan 19, 2022
View reviewed changes
Copy link
Contributor

@fyrchik fyrchik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! We need only to fix c.evictObjects argument before to remove right number of elements.
Otherwise, LGTM

@fyrchik fyrchik mentioned this pull request Jan 19, 2022
Merged
@ZhangTao1596
Copy link
Contributor Author

Nice catch! We need only to fix c.evictObjects argument before to remove right number of elements. Otherwise, LGTM

Yeah. evictObjects argument needs fix too. Should I copy f1a6262 here?

@fyrchik
Copy link
Contributor

fyrchik commented Jan 19, 2022

@ZhangTao1596 yes, that works.

@ZhangTao1596
[nspcc-dev#1088] writecache: Fix small flushed when persist
e1a5e2c 
Signed-off-by: ZhangTao1596 <zhangtao@ngd.neo.org>
@ZhangTao1596
Copy link
Contributor Author

@ZhangTao1596 yes, that works.

Done.

@fyrchik fyrchik merged commit ac82899 into nspcc-dev:master Jan 19, 2022
@ZhangTao1596 ZhangTao1596 deleted the fix-small-flushed branch January 19, 2022 10:00
aprasolova pushed a commit to aprasolova/neofs-node that referenced this pull request Mar 5, 2022
@ZhangTao1596 @aprasolova
[nspcc-dev#1088] writecache: Fix small flushed when persist
9be2897 
Signed-off-by: ZhangTao1596 <zhangtao@ngd.neo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fyrchik fyrchik fyrchik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.27.5
Development

Successfully merging this pull request may close these issues.
3 participants
@ZhangTao1596 @fyrchik @alexvanin