Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate session token on the node #2898

Closed
smallhive opened this issue Jul 25, 2024 · 2 comments · Fixed by #2903
Closed

Validate session token on the node #2898

smallhive opened this issue Jul 25, 2024 · 2 comments · Fixed by #2903
Assignees
Labels
enhancement Improving existing functionality I4 No visible changes S3 Minimally significant U2 Seriously planned
Milestone

Comments

@smallhive
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Using session tokens with bucket operations like create/delete bucket is an async story. In the SDK we use Waiter to get the successful result of such operations.

Despite this, if the session token is expired, the waiter will wait until timeout, because the request was correct, and correctly signed.

Describe the solution you'd like

It would be perfect if the node were requested immediately if the session token expired, was wrong by any parameter, etc.
Or even in any other requests, when node can check something

Additional context

Receiving any error on any request to the node can make the developer's life easier

@smallhive smallhive added the enhancement Improving existing functionality label Jul 25, 2024
@carpawell
Copy link
Member

carpawell commented Jul 25, 2024

Can you give an example operation that does not work? TBH, I thought that expiration is checked immediately.

@roman-khimov roman-khimov added U2 Seriously planned S3 Minimally significant I4 No visible changes labels Jul 25, 2024
@roman-khimov roman-khimov added this to the v0.43.0 milestone Jul 25, 2024
@smallhive
Copy link
Contributor Author

ContainerPut. If the token has expired there is no immediate response to the client with error

@carpawell carpawell self-assigned this Jul 26, 2024
carpawell added a commit that referenced this issue Jul 29, 2024
Closes #2898.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit that referenced this issue Jul 30, 2024
Closes #2898.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit that referenced this issue Jul 30, 2024
Closes #2898.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit that referenced this issue Jul 30, 2024
Closes #2898.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving existing functionality I4 No visible changes S3 Minimally significant U2 Seriously planned
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants