Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta.DB.Open(readOnly) does not move metabase in RO mode #2889

Closed
carpawell opened this issue Jul 9, 2024 · 2 comments · Fixed by #3000
Closed

meta.DB.Open(readOnly) does not move metabase in RO mode #2889

carpawell opened this issue Jul 9, 2024 · 2 comments · Fixed by #3000
Assignees
Labels
bug Something isn't working good first issue Good for newcomers I4 No visible changes S4 Routine U4 Nothing urgent

Comments

@carpawell
Copy link
Member

Expected Behavior

Metabase is asked to open bbolt in RO, and I expect the internal state to be RO too.

Current Behavior

Bbolt is opened in RO, however, metabase accepts write operations and returns bbolt's error.

Possible Solution

Open sets mode to RO (additional test for it is also good).

Context

Firstly found in #2884.

@carpawell carpawell added the bug Something isn't working label Jul 9, 2024
@roman-khimov roman-khimov added U4 Nothing urgent S4 Routine I4 No visible changes good first issue Good for newcomers labels Jul 16, 2024
@roman-khimov
Copy link
Member

Bbolt is opened in RO

Which is technically sufficient.

metabase accepts write operations and returns bbolt's error.

You want it to return some other specific error?

@carpawell
Copy link
Member Author

Which is technically sufficient.

Sure, that is how it should be done, but there are also some additional things in our code related to RO/RW states that currently behave strangely.

You want it to return some other specific error?

We have everything for it: a code, internal state, and check in every method but opening in RO mode make it useless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers I4 No visible changes S4 Routine U4 Nothing urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants