-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
404 errors are critical for big TTL values #2768
Comments
It's easy to revert, although this just means that our TTLs don't work the way they were intended to. |
This defeats the purpose, although with additional signatures this can in fact substitute TTL. |
That is S0 to me. The commit is already merged and updating sometimes does not allow deleting big objects with timeout error. Requests spam does not allow proper work even after a single multiplied request on my laptop. That is also a discussion to me cause I am not sure how that should be solved. |
This reverts commit 021cdfa because it strangely breaks our communication right now, see nspcc-dev/neofs-node#2768 Signed-off-by: Roman Khimov <roman@nspcc.ru>
Let's do nspcc-dev/neofs-sdk-go#567 and then think of associated problems, they can't be fixed quickly. |
OK, can be done this way. Not S0 then (but still a discussion?). A few links to the issue's solver: TTL is decoded here and then sent to the next node here (then repeat this one more time on the other node too). A lot of timeouts can be faced when running int tests, and a lot of debug logs about the same object being searched on every container node. |
Node does not like it: nspcc-dev/neofs-sdk-go#562. It starts forwarding requests and receives them back.
Expected Behavior
TTL describes the max forwarding number.
Current Behavior
TTL describes how many times you may try to search for objects. If there is no such object at all, there are 8 request forwardings even if you are the initiator of the request forwarding, you receive it back cause you are the container's part and the forwarder wants you to try.
Possible Solution
Not sure. Mb turn forwarding off in the object services? Spawn only requests with TTL=2 manually? Track forwardings chain and do not continue if you notice a cycle?
Steps to Reproduce (for bugs)
Update to the provided SDK version and try to get non-existing object. Or delete it. See logs that are bigger than you are expecting.
Context
Regression
nspcc-dev/neofs-sdk-go#562
The text was updated successfully, but these errors were encountered: