Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status code may lead to client cache invalidation #2767

Closed
carpawell opened this issue Mar 7, 2024 · 1 comment · Fixed by #2781
Closed

Status code may lead to client cache invalidation #2767

carpawell opened this issue Mar 7, 2024 · 1 comment · Fixed by #2781
Labels
bug Something isn't working I4 No visible changes neofs-storage Storage node application issues S4 Routine U2 Seriously planned
Milestone

Comments

@carpawell
Copy link
Member

Is your feature request related to a problem? Please describe.

Saw in logs:

2024-03-01T17:28:48.160Z	info	cache/multi.go:212	invalidated cached clients to the node caused by the error	{"address group": ["/dns4/s03.neofs.devenv/tcp/8080"], "error": "/dns4/s03.neofs.devenv/tcp/8080 node client: status: code = 2052 message = object already removed"}

Describe the solution you'd like

Do not drop connections because of status errors. Status response means that node responds.

Describe alternatives you've considered

Do not have any.

@carpawell carpawell added bug Something isn't working question Further information is requested neofs-storage Storage node application issues labels Mar 7, 2024
@carpawell
Copy link
Member Author

Also

2024-03-01T17:35:54.417Z	info	cache/multi.go:212	invalidated cached clients to the node caused by the error	{"address group": ["/dns4/s04.neofs.devenv/tcp/8082/tls", "/dns4/s04.neofs.devenv/tcp/8080"], "error": "/dns4/s04.neofs.devenv/tcp/8080 node client: status: code = 1024 message = node outside the container"}

@roman-khimov roman-khimov added this to the v0.41.0 milestone Mar 8, 2024
@roman-khimov roman-khimov added U2 Seriously planned S4 Routine I4 No visible changes and removed question Further information is requested labels Mar 8, 2024
cthulhu-rider added a commit that referenced this issue Mar 19, 2024
Previously, storage node closed connection with the remote node on any
status response from it for configured period of time (e.g. 30s). This
was fundamentally incorrect since status responses can only come from
"healthy" nodes.

From now status responses don't affect inter-node connections.

Closes #2767.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider added a commit that referenced this issue Mar 19, 2024
Previously, storage node closed connection with the remote node on any
status response from it for configured period of time (e.g. 30s). This
was fundamentally incorrect since status responses can only come from
"healthy" nodes.

From now status responses don't affect inter-node connections.

Closes #2767.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider added a commit that referenced this issue Mar 19, 2024
Previously, storage node closed connection with the remote node on any
status response from it for configured period of time (e.g. 30s). This
was fundamentally incorrect since status responses can only come from
"healthy" nodes.

From now status responses don't affect inter-node connections.

Fixes #2767.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider added a commit that referenced this issue Mar 19, 2024
Previously, storage node closed connection with the remote node on any
status response from it for configured period of time (e.g. 30s). This
was fundamentally incorrect since status responses can only come from
"healthy" nodes.

From now status responses don't affect inter-node connections.

Fixes #2767.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working I4 No visible changes neofs-storage Storage node application issues S4 Routine U2 Seriously planned
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants