Storage node can update its network state to any value

[cthulhu-rider]

• related Storage node can register in the network with any status #1796

Similar problem with state updating. It works similar to network registration but with other request - UpdateState.

Expected Behavior

Inner Ring does not allow to set node's state other than ONLINE or OFFLINE.

Current Behavior

Inner Ring allows to set any state.

Possible Solution

Check the state during processing.

Steps to Reproduce (for bugs)

1. make NeoFS CLI to send unsupported states. For example replace

   neofs-node/cmd/neofs-cli/modules/control/set_netmap_status.go

   Line 53 in d6fef68

   common.ExitOnErr(cmd, "", fmt.Errorf("unsupported status %s", st))

   with status = 321
2. build dirty NeoFS CLI $ make bin/neofs-cli
3. run NeoFS Developer Environment with the built version using make up/basic
4. exec $ ./bin/neofs-cli --endpoint s01.neofs.devenv:8081 --wallet ../devenv/services/storage/wallet01.json control set-status --status aaa
5. see Inner Ring logs

info	netmap/handlers.go:66	notification	{"type": "update peer state", "key": "022bb4041c50d607ff871dec7e4cd7778388e0ea6849d84ccbd9aa8f32e16a8131"}
debug	client/notary.go:404	notary request with prepared main TX invoked	{"fallback_valid_for": 40, "tx_hash": "c06e69162f87fd6609fd3a8861c1ed926657363f11d9c914a9a426195ba824cd"}
debug	subscriber/subscriber.go:136	new notification event from sidechain	{"name": "UpdateStateSuccess"}

Regression

No. Bug is very old.

Your Environment

• NeoFS Storage node: neofs-node@v0.32.0
• NeoFS CLI: neofs-cli@v0.32.0
• NeoFS Developer Environment: neofs-dev-env@c4ceb1c5854816cebcf23580853fda294c2d2c60

[cthulhu-rider]

While Inner Ring is a last resort of verification, maybe we need to check states also before calling the Netmap contract in order to not produce invalid requests.