Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persist shard IDs to metabase #1204

Closed
fyrchik opened this issue Mar 1, 2022 · 0 comments · Fixed by #1206
Closed

Persist shard IDs to metabase #1204

fyrchik opened this issue Mar 1, 2022 · 0 comments · Fixed by #1206
Assignees
@fyrchik
Milestone
v0.27.7

Comments

@fyrchik
Copy link
Contributor

fyrchik commented Mar 1, 2022

When node starts, new IDs are generated, so HRW sort order has a high probability of becoming suboptimal for already stored objects. We could store shard ID in the metabase to avoid this issue.
@fyrchik fyrchik mentioned this issue Mar 2, 2022
Merged
aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue Mar 5, 2022
@fyrchik @aprasolova
[nspcc-dev#1204] shard: Save ID in the metabase
137b504 
`AddShard` must return shard id, so we temporarily open metabase
there.

Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fyrchik fyrchik

Labels
None yet
Projects
None yet
Milestone
v0.27.7
Development

Successfully merging a pull request may close this issue.

Save shard IDs in metabase fyrchik/neofs-node
2 participants
@alexvanin @fyrchik