Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IsActive() status when main chain disabled #1025

Closed
alexvanin opened this issue Dec 8, 2021 · 2 comments · Fixed by #1076
Closed

IsActive() status when main chain disabled #1025

alexvanin opened this issue Dec 8, 2021 · 2 comments · Fixed by #1076
Assignees
@cthulhu-rider
Labels
help wanted Extra attention is needed neofs-ir Inner Ring node application issues
Milestone
v0.27.4

Comments

@alexvanin
Copy link
Contributor

During the tests I had a situation when main chain was disabled, but alphabet node still consideres non active (IsActive() returns false). Not sure if this is correct behavior. Unfortunately it is quite hard to keep track of such things when you have so many running modes.
@cthulhu-rider cthulhu-rider self-assigned this Jan 10, 2022
@cthulhu-rider
Copy link
Contributor

cthulhu-rider commented Jan 11, 2022 •
edited
Loading

@alexvanin the problem occurs in notary environment when we disable mainchain in config without_mainnet. In this case IsActive status is calculated from the result of calling the InnerRingList method of Netmap contract. In dev env it returns empty list.

@alexvanin
Copy link
Contributor Author

Netmap contract should be used as the source of the Inner Ring nodes when notary is disabled. I propose to fix that and fetch Inner Ring list from RoleManagement contract in this case. What do you think about that?

cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue Jan 11, 2022
[nspcc-dev#1025] ir: Read IR list from role management contract w/o m…
48bbcc4 
…ainchain

If mainchain is disabled in IR config then the node should read inner
ring list via role management contract.

Use `NeoFSAlphabetList` method of morph client as IR lister if
`withoutMainNet` flag is set in IR app.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
@cthulhu-rider cthulhu-rider mentioned this issue Jan 11, 2022
Merged
aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue Mar 5, 2022
@aprasolova
[nspcc-dev#1025] ir: Read IR list from role management contract w/o m…
d547379 
…ainchain

If mainchain is disabled in IR config then the node should read inner
ring list via role management contract.

Use `NeoFSAlphabetList` method of morph client as IR lister if
`withoutMainNet` flag is set in IR app.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cthulhu-rider cthulhu-rider

Labels
help wanted Extra attention is needed neofs-ir Inner Ring node application issues
Projects
None yet
Milestone
v0.27.4
Development

Successfully merging a pull request may close this issue.

Read IR list from role management contract w/o mainchain cthulhu-rider/neofs-node
2 participants
@alexvanin @cthulhu-rider