Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

Different heading formation in GET and HEAD #125

Closed
cthulhu-rider opened this issue Feb 7, 2022 · 2 comments · Fixed by #127
Closed

Different heading formation in GET and HEAD #125

cthulhu-rider opened this issue Feb 7, 2022 · 2 comments · Fixed by #127
Assignees
Labels
bug Something isn't working

Comments

@cthulhu-rider
Copy link
Contributor

Seems like GET and HEAD handlers form identity headers differently.

@cthulhu-rider cthulhu-rider added bug Something isn't working triage labels Feb 7, 2022
@KirillovDenis
Copy link
Contributor

I'm not sure this is a bug because r.Response.Header.Set function normalize header key (if disableNormalizing isn't set). But I agree we should use the same keys (probable we should define constants for that)

@KirillovDenis
Copy link
Contributor

KirillovDenis commented Feb 15, 2022

It turns out we disabled normalization.

I suppose the reason is reverse proxy:

Disabled header names' normalization may be useful only for proxying
incoming requests to other servers expecting case-sensitive
header names. See valyala/fasthttp#57
for details.

cthulhu-rider pushed a commit that referenced this issue Feb 15, 2022
Signed-off-by: Denis Kirillov <denis@nspcc.ru>
cthulhu-rider pushed a commit that referenced this issue Feb 15, 2022
Signed-off-by: Denis Kirillov <denis@nspcc.ru>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants