feat/add meta information consistency attribute #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carpawell
requested review from
cthulhu-rider and
roman-khimov
as code owners
|
Naming is from the issue, have no suggestion from my side. I do not like that attribute idea, cause it is more like a core feature for me, every container gonna have it and it changes the game significantly, but agree that an attribute thing makes it more flexible than a new field. |
carpawell
force-pushed
the
feat/container-meta-info-consistency
branch
from
252eb6b
to
ab48be9
Compare
|
Comments may be adjusted in the future when we will have more understanding of what the meta flow looks like. |
container/types.proto
Outdated
| // * __NEOFS__METAINFO_CONSISTENCY \ | ||
| // Policy rule that defines the condition under which an object is considered | ||
| // processed. Acceptable values and meanings: | ||
| // 1. <empty>/<missing attribute>: SN does not process objects' meta |
There was a problem hiding this comment.
attr value cannot be empty as stated above, absence is enough
There was a problem hiding this comment.
ok, reworded it to sound like "other cases" with the old behavior
container/types.proto
Outdated
| // 2. "strict": SN processes objects' meta information, it is validated, | ||
| // indexed and signed accordingly by a required minimal number of nodes | ||
| // that are included in the container, a corresponding object inclusion | ||
| // notification can be catch |
There was a problem hiding this comment.
Suggested change
| // notification can be catch | |
| // notification can be caught |
Closes #300. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell
force-pushed
the
feat/container-meta-info-consistency
branch
from
ab48be9
to
a2baf6c
Compare
roman-khimov
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #300.