-
Notifications
You must be signed in to change notification settings - Fork 11
Add observability agent application for clusters #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
aa61692 to
7948758
Compare
14ada43 to
b7c70c5
Compare
| versions: | ||
| - version: 0.1.0 | ||
| repo: https://github.com/nscaledev/k8s-deploy-observability-agent | ||
| branch: main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will be tagged when an RC is ready
d46c01e to
1964d54
Compare
| values := map[string]any{ | ||
| "clusterName": cluster.Name, | ||
| "region": cluster.Labels[RegionNameLabel], | ||
| "environment": "nks", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't have a clear way to obtain the currently expected values for this required value.
the value expects e.g.
- glo1
- sta1
the argument for setting it to nks is that it clearly identifies telemetry coming from an NKS cluster via the observability agent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we standardise all of our clusters to use the canonical region name such as no-glo1-dev, no-glo1, no-sta1 etc. then we could remove the environment key altogether.
1964d54 to
9d04813
Compare
I am on board with the idea of optionally setting up telemetry for my clusters. Say I have a Prometheus running centrally, how do I tell this agent to send metrics to it? |
@squaremo |
I don't think this is a good idea. That would mean the chart, and this component, are specialised to our deployment by default -- which is wrong in principle (to wit: "don't give open things proprietary dependencies"); but also in practice an avoidable pain, for e.g., local deployments. Better to default it to empty and provide the deployment particulars in our own manifests. |
This PR introduces observability agent support for Kubernetes clusters, enabling telemetry collection and forwarding to the centralised observability platform.
The approach taken is a temporary™️ one to getting the agent on customer clusters. An ADR was written detailing this decision, here. We will review the approach in future.
Caveat for testing: right now the chart requires a manual application of the aggregator basic auth secret until mTLS is added in the coming week.
Summary
k8s-deploy-observability-agentchart