Add API Error Propagation #211
Open
+101
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At present we just pass this through as a raw error, which will ultimately end up as a 500 to the user. Instead we should unpack the error so it can be propagated for root cause analysis. I've backed this up with tests and fixed the long standing crash when a gateway error ocurrs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #211 +/- ##
==========================================
+ Coverage 30.10% 30.46% +0.36%
==========================================
Files 66 66
Lines 3534 3538 +4
==========================================
+ Hits 1064 1078 +14
+ Misses 2374 2361 -13
- Partials 96 99 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present we just pass this through as a raw error, which will ultimately end up as a 500 to the user. Instead we should unpack the error so it can be propagated for root cause analysis. I've backed this up with tests and fixed the long standing crash when a gateway error ocurrs.