fix: set accepted client sockets to non-blocking mode - #18
Open
EclipseWraith wants to merge 1 commit into
Open
Conversation
On Linux, accept() does not inherit O_NONBLOCK from the listening socket. This caused the daemon's recv() loop to block indefinitely after reading the initial message chunk, preventing any Python client from completing initialization. Added fcntl(F_SETFL, O_NONBLOCK) on accepted client sockets immediately after accept() to match the server socket's non-blocking behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Linux, accept() does not inherit O_NONBLOCK from the listening socket. This caused the recv() loop in start_server()
to block indefinitely after reading the first message, preventing Python clients from completing initialization.
Fixed by applying fcntl(F_SETFL, O_NONBLOCK) to accepted client sockets immediately after accept().
Tested on Ubuntu 24.04 (WSL2).