This repository has been archived by the owner on Mar 22, 2021. It is now read-only.
make ActiveRecord::NotFound exception configurable #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in order to use other exceptions, if no ActiveRecord is used.
|
I don't understand why it fails in Travis. It passes for me with rubies 2.1.7 and 2.3.0 |
|
after adding 2 more versions to Travis and no other change, now 2.1.0 runs ok but 2.1.7 fails... sigh... |
|
Is this the only thing preventing Knock from being independent of Active Record? |
|
@colinramsay I am using this in an rails 5 API with no ActiveRecord and it is fine so far. |
|
@eturino Thank you for this. I was hoping to come up with a solution other than configuration but I haven't had time to work on it yet. Could you rebase this into one commit before I merge it? Thanks 👍 |
|
@nsarno I think you can use the new Github feature of "Squash and merge". I've been using them at work for quite some time now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in order to use other exceptions, if no ActiveRecord is used.