Add new redirect objects #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fformica
commented
Jan 31, 2024
rest/redirect.go
Outdated
|
|
||
| // List returns the configured redirects. | ||
| // | ||
| // NS1 API docs: TBD |
There was a problem hiding this comment.
We don't have these docs yet :( Maybe we can add them in a later PR, or delay this one?
dmavrommatis
previously approved these changes
Mar 8, 2024
dmavrommatis
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the new redirect objects (not yet public), and fixing unit tests.
Also, removing deprecated golint, as the functionality should be included in go vet now