fix(gradle): ignore test enums when atomizing#34974
Merged
Conversation
👷 Deploy Preview for nx-docs processing.
|
👷 Deploy Preview for nx-dev processing.
|
Contributor
|
View your CI Pipeline Execution ↗ for commit e9af569
☁️ Nx Cloud last updated this comment at |
MaxKless
approved these changes
Mar 24, 2026
lourw
deleted the
feature/nxc-4133-ensure-that-regex-parsing-ignores-enums
branch
FrozenPandaz
pushed a commit
that referenced
this pull request
Mar 26, 2026
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior When the Gradle plugin's regex-based test parser (used as a fallback when AST parsing fails) encounters a Kotlin file containing enum classes, those enum classes are incorrectly included as test atomization targets. This causes spurious test entries to appear for enum types like TestStatus or Priority that are not actual test classes. ## Expected Behavior Enum classes are excluded from the list of discovered test classes during atomization, consistent with how abstract classes and annotation classes are already filtered out. Only real test classes should be identified as atomization targets. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # (cherry picked from commit 4a073cd)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
When the Gradle plugin's regex-based test parser (used as a fallback when AST parsing fails) encounters a Kotlin file
containing enum classes, those enum classes are incorrectly included as test atomization targets. This causes spurious
test entries to appear for enum types like TestStatus or Priority that are not actual test classes.
Expected Behavior
Enum classes are excluded from the list of discovered test classes during atomization, consistent with how abstract
classes and annotation classes are already filtered out. Only real test classes should be identified as atomization targets.
Related Issue(s)
Fixes #