-
Notifications
You must be signed in to change notification settings - Fork 2.6k
fix(core): fix vitest test runner options for angular in cnw #33921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit e6a30e5
☁️ Nx Cloud last updated this comment at |
Co-authored-by: leosvelperez <leosvelperez@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nx Cloud has identified a possible root cause for your failed CI:
Our PR modifies Angular/Vitest workspace creation options, while the failing e2e-maven tests call the Spring Initializr API which recently changed validation rules to reject Spring Boot 3.4.0 (requiring >=3.5.0). This is an external service change unrelated to our PR changes, affecting pre-existing hardcoded version configuration in the Maven test utilities.
No code changes were suggested for this issue.
If the issue was transient, you can trigger a rerun:
🎓 Learn more about Self-Healing CI on nx.dev
## Current Behavior Creating a new Angular workspace with Vitest results in no test setup being generated. This happens because the `vitest` option is no longer available, and instead, there are two options: `vitest-angular` and `vitest-analog`. ## Expected Behavior Creating a new Angular workspace should prompt for Vitest with Angular or Vitest with Analog to set up the tests. --------- Co-authored-by: nx-cloud[bot] <71083854+nx-cloud[bot]@users.noreply.github.com> Co-authored-by: leosvelperez <leosvelperez@users.noreply.github.com> Co-authored-by: Jack Hsu <jack.hsu@gmail.com>

Current Behavior
Creating a new Angular workspace with Vitest results in no test setup being generated. This happens because the
vitestoption is no longer available, and instead, there are two options:vitest-angularandvitest-analog.Expected Behavior
Creating a new Angular workspace should prompt for Vitest with Angular or Vitest with Analog to set up the tests.