fix(misc): check for packages existence to detect pnpm workspaces setup
#32474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx affected --targets=lint,test,build,e2e,e2e-c... |
✅ Succeeded | 55m 23s | View ↗ |
nx run-many -t check-imports check-commit check... |
✅ Succeeded | 2m 5s | View ↗ |
nx-cloud record -- nx-cloud conformance:check |
✅ Succeeded | 2s | View ↗ |
nx-cloud record -- nx format:check |
✅ Succeeded | 6s | View ↗ |
nx-cloud record -- nx sync:check |
✅ Succeeded | 5s | View ↗ |
nx documentation |
✅ Succeeded | 58s | View ↗ |
nx affected -t e2e-macos-local --parallel=1 --b... |
✅ Succeeded | 20m 39s | View ↗ |
☁️ Nx Cloud last updated this comment at 2025-08-22 14:57:00 UTC
Coly010
approved these changes
Aug 22, 2025
leosvelperez
force-pushed
the
misc/fix-pnpm-workspaces-detection
branch
from
aad79e0 to
4683e76
Compare
leosvelperez
force-pushed
the
misc/fix-pnpm-workspaces-detection
branch
from
4683e76 to
21069dd
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
leosvelperez
force-pushed
the
misc/fix-pnpm-workspaces-detection
branch
from
21069dd to
c651797
Compare
FrozenPandaz
approved these changes
Aug 22, 2025
FrozenPandaz
pushed a commit
that referenced
this pull request
Aug 22, 2025
…etup (#32474) ## Current Behavior When detecting whether a workspace is set up with pnpm workspaces, we only check for the existence of the `pnpm-workspace.yaml` file. While most of the time that's enough, it's not entirely correct because that file can exist without a `packages` entry and solely contain other settings. ## Expected Behavior When detecting whether a workspace is set up with pnpm workspaces, we should check for the existence of the `pnpm-workspace.yaml` file and the `packages` entry. (cherry picked from commit 0494d09)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When detecting whether a workspace is set up with pnpm workspaces, we only check for the existence of the
pnpm-workspace.yamlfile. While most of the time that's enough, it's not entirely correct because that file can exist without apackagesentry and solely contain other settings.Expected Behavior
When detecting whether a workspace is set up with pnpm workspaces, we should check for the existence of the
pnpm-workspace.yamlfile and thepackagesentry.