fix(testing): update jest ci target to forward top level args #31379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit d0ba8d3.
☁️ Nx Cloud last updated this comment at |
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx create-nx-workspace@0.0.0-pr-31379-d0ba8d3 my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-31379-d0ba8d3
To request a new release for this pull request, mention someone from the Nx team or the |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Jest dependsOn configuration for the Nx plugin to replace string-based dependencies with structured objects, enabling the forwarding of top-level arguments.
- Updated dependsOn arrays in the plugin and tests to use objects instead of strings.
- Ensured that the top-level Jest target forwards arguments to dependent targets.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/jest/src/plugins/plugin.ts | Updated dependsOn configuration for Jest targets using structured objects. |
| packages/jest/src/plugins/plugin.spec.ts | Updated tests to reflect the new structured dependsOn format. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
dependsOnconfiguration for Jest targets in the Nx plugin to improve flexibility and maintainability. The changes replace string-based dependencies with structured objects, ensuring better alignment with Nx's target configuration standards.This PR updates the
dependsOnconfiguration for JestciTargetto ensure that top-level args are passed on if the parent target has a dependsOn for other targets.For example if i pass
nx run-many e2e-ci -- --json --outputFile=my-test-results.jsonthe options:--json--outputFileShould be forwarded to the dependent targets.