Skip to content

fix(release): only error on missing manifestsToUpdate if a project is being directly processed #31004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2025

Conversation

JamesHenry
Copy link
Collaborator

@JamesHenry JamesHenry commented May 2, 2025

Current Behavior

If filtering by groups or projects, we still validate that all manifestRootsToUpdate are valid and in place even for projects which are not captured by those filters (directly and indirectly via dependencies).

Expected Behavior

We only validate the manifestRootsToUpdate that are applicable to the current versioning run, taking the filters into account.

Related Issue(s)

Fixes #

Copy link

vercel bot commented May 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview May 2, 2025 3:00pm

Copy link

nx-cloud bot commented May 2, 2025

View your CI Pipeline Execution ↗ for commit 957c9ff.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 39m 10s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 18s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 3s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 1s View ↗
nx documentation ✅ Succeeded 1m 21s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-02 15:46:08 UTC

Copy link

github-actions bot commented May 2, 2025

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx create-nx-workspace@0.0.0-pr-31004-957c9ff my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-31004-957c9ff
Release details 📑
Published version 0.0.0-pr-31004-957c9ff
Triggered by @JamesHenry
Branch nx-release-version-filter-validation
Commit 957c9ff
Workflow run 14798366752

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

@JamesHenry JamesHenry marked this pull request as ready for review May 2, 2025 16:18
@JamesHenry JamesHenry requested a review from a team as a code owner May 2, 2025 16:18
@JamesHenry JamesHenry requested a review from FrozenPandaz May 2, 2025 16:18
@JamesHenry JamesHenry enabled auto-merge (squash) May 2, 2025 16:20
@JamesHenry JamesHenry merged commit 8b3e9f7 into master May 2, 2025
6 checks passed
@JamesHenry JamesHenry deleted the nx-release-version-filter-validation branch May 2, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants