fix(angular): convert-to-rspack should ensure zone.js is not treated as local file #30966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit 014524c.
☁️ Nx Cloud last updated this comment at |
jaysoo
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The
@nx/angular:convert-to-rspackrelies onrequire.resolveto check if entries listed in thepolyfillsarray is an npm package.However, in some circumstances such as generating a new app,
zone.jsis not yet installed and therefore require.resolve will not resolve the package.Expected Behavior
Ensure that
zone.jsis special cased as it is a polyfill that is always needed to be treated as a package.This is also the only polyfill that is set during generation of an app and therefore is the only package that should run into this issue.