Skip to content

fix(core): throw errors when task graph has invalid continuous tasks #30924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025

Conversation

FrozenPandaz
Copy link
Collaborator

Current Behavior

  1. The continuous property is not present in the nx.json schema.
  2. When tasks which do not support parallelism depend on a continuous task, task execution is deadlocked.
  3. Circular dependencies between continuous dependencies are allowed.

Expected Behavior

  1. The continuous property is added to the nx.json schema.
  2. An error is thrown when tasks which do not support parallelism depends on a continuous task.
  3. Circular dependencies between continuous tasks are caught and thrown as an error.

Related Issue(s)

Fixes #

@FrozenPandaz FrozenPandaz requested a review from a team as a code owner April 29, 2025 18:39
Copy link

vercel bot commented Apr 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Apr 29, 2025 9:19pm

Copy link

nx-cloud bot commented Apr 29, 2025

View your CI Pipeline Execution ↗ for commit 83bd627.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-ci ✅ Succeeded 10m 9s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 19s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗
nx documentation ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-29 22:50:47 UTC

@FrozenPandaz FrozenPandaz merged commit 84c4dc5 into master Apr 29, 2025
6 checks passed
@FrozenPandaz FrozenPandaz deleted the continuous-fixes branch April 29, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants