feat(core)!: remove legacy cache flag from nx.json #30787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgentEnder
requested review from
FrozenPandaz,
jaysoo and
a team
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
View your CI Pipeline Execution ↗ for commit 902b817.
☁️ Nx Cloud last updated this comment at |
AgentEnder
force-pushed
the
feat/remove-legacy-cache
branch
2 times, most recently
from
3209542 to
0d2c18e
Compare
AgentEnder
force-pushed
the
feat/remove-legacy-cache
branch
from
0d2c18e to
cc1e13a
Compare
AgentEnder
force-pushed
the
feat/remove-legacy-cache
branch
from
cc1e13a to
5cedb95
Compare
AgentEnder
force-pushed
the
feat/remove-legacy-cache
branch
from
5cedb95 to
51b11a5
Compare
FrozenPandaz
requested changes
Apr 24, 2025
| @@ -0,0 +1,27 @@ | |||
| #### Use Legacy Cache | |||
|
|
|||
| Removes `useLegacyCache` as it is no longer functional in Nx 21 | |||
There was a problem hiding this comment.
Suggested change
| Removes `useLegacyCache` as it is no longer functional in Nx 21 | |
| Removes `useLegacyCache` from `nx.json` as it is no longer functional in Nx 21 |
| return; | ||
| } | ||
|
|
||
| // If workspaces had `enableDbCache` we can just delete the property as the db cache is enabled by default in nx v20 |
There was a problem hiding this comment.
This comment doesn't make sense
|
|
||
| // If workspaces had `enableDbCache` we can just delete the property as the db cache is enabled by default in nx v20 | ||
| if ((nxJson as any).useLegacyCache) { | ||
| delete (nxJson as any).enableDbCache; |
There was a problem hiding this comment.
Suggested change
| delete (nxJson as any).enableDbCache; | |
| delete (nxJson as any).useLegacyCache; |
FrozenPandaz
approved these changes
Apr 24, 2025
| @@ -1682,6 +1684,12 @@ async function runMigrations( | |||
| title: `No changes were made from running '${opts.runMigrations}'. This workspace is up to date!`, | |||
| }); | |||
| } | |||
| if (nextSteps.length > 0) { | |||
| output.log({ | |||
| title: `Some migrations require additional steps to be completed, please check the following:`, | |||
There was a problem hiding this comment.
Suggested change
| title: `Some migrations require additional steps to be completed, please check the following:`, | |
| title: `Some migrations have additional information. See below:`, |
| if (!Array.isArray(value)) { | ||
| return false; | ||
| } | ||
| return value.reduce((acc, v) => acc && typeof v === 'string', true); |
There was a problem hiding this comment.
Suggested change
| return value.reduce((acc, v) => acc && typeof v === 'string', true); | |
| return value.every((v) => typeof v === 'string'); |
| @@ -43,5 +43,11 @@ export async function repair( | |||
| title: `No changes were necessary. This workspace is up to date!`, | |||
| }); | |||
| } | |||
| if (nextSteps.length) { | |||
| output.log({ | |||
| title: 'Some next steps may be necessary to complete the repair:', | |||
There was a problem hiding this comment.
Suggested change
| title: 'Some next steps may be necessary to complete the repair:', | |
| title: 'Some repairs have additional information. See below:', |
| @@ -8,6 +8,7 @@ import { | |||
|
|
|||
| import type { NxJsonConfiguration } from './nx-json'; | |||
| import { Schema } from '../utils/params'; | |||
| import { Tree } from '../generators/tree'; | |||
| @@ -8,6 +8,7 @@ import { | |||
|
|
|||
| import type { NxJsonConfiguration } from './nx-json'; | |||
| import { Schema } from '../utils/params'; | |||
|
|
||
| #### Sample Code Changes | ||
|
|
||
| Removes `tasksRunnerOptions` from `nx.json` if it would be empty after removing custom tasks runners. |
There was a problem hiding this comment.
Suggested change
| Removes `tasksRunnerOptions` from `nx.json` if it would be empty after removing custom tasks runners. | |
| Removes custom task runner configuration from `nx.json` |
AgentEnder
force-pushed
the
feat/remove-legacy-cache
branch
from
2e6f7fa to
aac22fc
Compare
AgentEnder
force-pushed
the
feat/remove-legacy-cache
branch
from
aac22fc to
902b817
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
useLegacyCache is there for opting out of db cache impl
Expected Behavior
db cache is only cache when at all possible, unfortunately on wasm builds it is still unsupported.
Related Issue(s)
Fixes #