-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat(nest): update NestJS version to 7.0.0 #2921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cb8b6b2
to
adb2319
Compare
Thanks for the contribution! Would you mind listing out any Breaking Changes in NestJS 7.0.0 and highlight any changes that were made? I see rxjs is now a peer dependency? |
@FrozenPandaz thanks for reviewing! (As far as I can tell...) The only real breaking change in NestJS core is dropping support for Node v8. Other than that, users of the packages I've been using Nest v7 it since it's release in my Nx projects and I only needed to change how I used GraphQL. Since Kamil did an awesome job keeping
After that we can get rid of the Let me know if you need anything else, or if you want me to list this somewhere specific. The From looking at it though, we should probably also add
|
9782e5c
to
7884038
Compare
@FrozenPandaz I pushed an updated version. The PR now also updates the dependencies in the top-level package.json (this is what breaks CI?). I also gave a shot at adding a migration script. Not sure if that's something that's desired, happy to remove again it if not :) |
5c58716
to
16bacff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding the migration file.
I think we should also provide migrations for the changes to imports.
Would you be able to give that a shot?
@FrozenPandaz for sure happy to take a look at that. Do you know of a similar migration that I could use as an example? |
Here is somewhere you can start? You may want to be more careful about which Symbols are brought over? |
4161216
to
b86e3a6
Compare
@FrozenPandaz that was a great pointer, I updated the migration to update the import from However, I have tried to rename the decorator ( |
738e12c
to
d1679ce
Compare
b86e3a6
to
215905b
Compare
215905b
to
6ca2fb9
Compare
@beeman just adjusted a couple of things on top of ur PR. Thx again for all ur contributions 🙏 . I also added a link to the NestJS migration docs, so ppl can check it out. If the pipeline looks good I'll merge it tomorrow |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This PR updates NestJS to the latest version. I've added the same versions that are used when creating a new app using the NestJS cli, including RxJS.
I've tested it in a playground and all seems to work as expected.