fix(linter): scope js and ts shared configs to js and ts files#28381
Merged
JamesHenry merged 1 commit intomasterfrom Oct 10, 2024
Merged
fix(linter): scope js and ts shared configs to js and ts files#28381JamesHenry merged 1 commit intomasterfrom
JamesHenry merged 1 commit intomasterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Contributor
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 0e51620. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
leosvelperez
force-pushed
the
eslint/fix-flat-angular-issue
branch
from
c960209 to
54dac49
Compare
leosvelperez
changed the title
leosvelperez
force-pushed
the
eslint/fix-flat-angular-issue
branch
from
54dac49 to
0e51620
Compare
JamesHenry
approved these changes
Oct 10, 2024
This was referenced Oct 14, 2024
jaysoo
pushed a commit
that referenced
this pull request
Oct 14, 2024
4 tasks
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
The
flat/javascriptandflat/typescriptshared configurations from the@nx/eslint-pluginare not scoped to the respective js and ts files. This causes them to apply to files they shouldn't apply to.Expected Behavior
The
flat/javascriptandflat/typescriptshared configurations from the@nx/eslint-pluginshould be scoped to the respective js and ts files.Related Issue(s)
Fixes #28347