Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix importing files with special characters #27484

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Conversation

FrozenPandaz
Copy link
Collaborator

@FrozenPandaz FrozenPandaz commented Aug 16, 2024

Current Behavior

Files which have special characters in the path cannot be imported.

Expected Behavior

Files which have special characters in the path can be imported.

Related Issue(s)

Fixes #27468

@FrozenPandaz FrozenPandaz requested a review from a team as a code owner August 16, 2024 15:51
@FrozenPandaz FrozenPandaz requested a review from Cammisuli August 16, 2024 15:51
Copy link

vercel bot commented Aug 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Aug 16, 2024 3:51pm

@FrozenPandaz FrozenPandaz merged commit a5b93b8 into master Aug 19, 2024
6 checks passed
@FrozenPandaz FrozenPandaz deleted the import-fix branch August 19, 2024 20:48
FrozenPandaz added a commit that referenced this pull request Aug 21, 2024
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

Files which have special characters in the path cannot be imported.

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

Files which have special characters in the path can be imported.

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #27468

(cherry picked from commit a5b93b8)
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Import] importing repo having files with special characters breaks the move
2 participants