Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testing): resolve jest utils in plugin from the @jest/core package location that jest uses #27422

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

leosvelperez
Copy link
Member

Current Behavior

In the @nx/jest/plugin some jest utils are imported from the location of the jest package to ensure the plugin uses the same utils the jest package would use. This is not entirely correct because the jest package doesn't directly depend on those utils, so they might not be resolved correctly.

Expected Behavior

The @nx/jest/plugin should import those jest utils from the location of the @jest/core package resolved from the jest package location, to ensure the plugin uses the same utils the jest package would use.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Aug 14, 2024
@leosvelperez leosvelperez requested a review from a team as a code owner August 14, 2024 10:13
Copy link

vercel bot commented Aug 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Aug 14, 2024 10:13am

@FrozenPandaz FrozenPandaz merged commit 17f09bc into master Aug 14, 2024
6 checks passed
@FrozenPandaz FrozenPandaz deleted the jest/fix-plugin-jest-util-imports branch August 14, 2024 14:48
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants