Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): merge package.json plugins and updated project.json plugin… #26952

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

FrozenPandaz
Copy link
Collaborator

… using v2

Current Behavior

The package.json handling is split between before and after plugins so it's confusing. Also, package.json nodes will get overwritten by plugins while others won't.

Expected Behavior

The package.json handling is merged. Also, the package.json nodes will always overwrite plugins as intended.

Related Issue(s)

Fixes #

@FrozenPandaz FrozenPandaz requested review from a team as code owners July 16, 2024 16:59
@FrozenPandaz FrozenPandaz requested a review from AgentEnder July 16, 2024 16:59
Copy link

vercel bot commented Jul 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jul 16, 2024 5:00pm

@FrozenPandaz FrozenPandaz enabled auto-merge (squash) July 16, 2024 17:36
@FrozenPandaz FrozenPandaz merged commit 51f5fe4 into master Jul 16, 2024
6 checks passed
@FrozenPandaz FrozenPandaz deleted the merge-json-plugins branch July 16, 2024 17:46
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants