Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testing): handle existing jest preset file correctly #23437

Merged
merged 1 commit into from
May 17, 2024

Conversation

leosvelperez
Copy link
Member

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #20449

Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview May 16, 2024 1:51pm

@leosvelperez leosvelperez self-assigned this May 16, 2024
@leosvelperez leosvelperez marked this pull request as ready for review May 16, 2024 14:49
@leosvelperez leosvelperez requested review from a team and Coly010 as code owners May 16, 2024 14:49
@leosvelperez leosvelperez requested review from AgentEnder and jaysoo May 16, 2024 14:49
@leosvelperez leosvelperez enabled auto-merge (squash) May 17, 2024 13:06
@leosvelperez leosvelperez merged commit 217a349 into master May 17, 2024
6 checks passed
@leosvelperez leosvelperez deleted the jest/fix-jest-preset-file-handling branch May 17, 2024 14:26
FrozenPandaz pushed a commit that referenced this pull request May 21, 2024
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #20449

(cherry picked from commit 217a349)
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nx does not recognize existing jest.preset files if using .cjs or .mjs
5 participants