fix(misc): various inference plugins caching should track changes #23315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgentEnder
requested review from
FrozenPandaz,
xiongemi,
a team and
Coly010
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 092b574. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
AgentEnder
force-pushed
the
fix/jest-plugin-cache
branch
2 times, most recently
from
8156a6b to
a25ab36
Compare
AgentEnder
force-pushed
the
fix/jest-plugin-cache
branch
from
a25ab36 to
31adc37
Compare
FrozenPandaz
requested changes
May 16, 2024
packages/gradle/src/plugin/nodes.ts
Outdated
| const targetsCache = existsSync(cachePath) ? readTargetsCache() : {}; | ||
|
|
||
| export const calculatedTargets: Record< | ||
| export const targetsCache = readTargetsCache(); |
| @@ -1063,6 +1064,9 @@ describe(`Plugin: ${PLUGIN_NAME}`, () => { | |||
| }), | |||
| 'libs/my-lib/package.json': `{}`, | |||
| }); | |||
|
|
|||
| await new Promise((res) => setTimeout(res, 2000)); // wait for the file to be created | |||
AgentEnder
force-pushed
the
fix/jest-plugin-cache
branch
from
6157ceb to
092b574
Compare
FrozenPandaz
approved these changes
May 23, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
May 24, 2024
…3315) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> ## Current Behavior Plugin's cache entries overwrite each other if multiple instances of the same plugin are running. They also don't remember previous cache states. ## Expected Behavior Plugin's caches grow as changes are made, and don't overwrite previous entries. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # (cherry picked from commit a4a185f)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Plugin's cache entries overwrite each other if multiple instances of the same plugin are running. They also don't remember previous cache states.
Expected Behavior
Plugin's caches grow as changes are made, and don't overwrite previous entries.
Related Issue(s)
Fixes #