feat(core): forward stdin to commands started via rust #21195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 7a15316. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
AgentEnder
force-pushed
the
feat/stdin-forwarding-rust
branch
from
2faaacd
to
ef069c5
Compare
AgentEnder
force-pushed
the
feat/stdin-forwarding-rust
branch
from
31b0264
to
b0f2ba7
Compare
Cammisuli
requested changes
Jan 22, 2024
AgentEnder
requested review from
a team,
FrozenPandaz and
vsavkin
as code owners
FrozenPandaz
approved these changes
Jan 22, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Commands ran via rust do not have any access to user input
Expected Behavior
Commands ran via rust receive stdin
Related Issue(s)
This removes the fix for #1666 - we believe the issue should no longer be relevant and it was causing the command runner to hang on MacOS - if it recurs, we will look into reapplying some version of the fix.
Fixes #8269