Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): move common options to target defaults #20583

Merged
merged 12 commits into from
Jan 9, 2024

Conversation

meeroslav
Copy link
Contributor

This PR does the following:

  • replace lint in targetDefaults during init with @nx/eslint:lint
  • removes output from the lint project generator
  • provides migration that:
    • replaces path/to/project with {projectRoot} in the lint file patterns
    • removes lintFilePatterns if it matches default value - {projectRoot}
    • removes outputs if not used in any of the projects
    • moves outputs to targetDefaults if used in some project(s)
    • removes eslintConfig if it matches the expected supported file name
    • removes inputs if they match the target defaults' inputs

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@meeroslav meeroslav added the scope: linter Issues related to Eslint support in Nx label Dec 5, 2023
@meeroslav meeroslav self-assigned this Dec 5, 2023
Copy link

vercel bot commented Dec 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jan 9, 2024 8:27am

Copy link
Member

@mandarini mandarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of questions!

@mandarini mandarini self-requested a review December 7, 2023 09:36
@meeroslav meeroslav removed the request for review from barbados-clemens December 22, 2023 07:45
@meeroslav meeroslav enabled auto-merge (rebase) January 8, 2024 11:33
auto-merge was automatically disabled January 8, 2024 22:59

Rebase failed

@meeroslav meeroslav enabled auto-merge (squash) January 9, 2024 08:23
@meeroslav meeroslav merged commit 03257e2 into nrwl:master Jan 9, 2024
6 checks passed
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: linter Issues related to Eslint support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants