-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(misc): introduce a way to set the project name/root format for all generators #18971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrozenPandaz
requested review from
meeroslav,
vsavkin,
mandarini and
a team
as code owners
September 1, 2023 16:25
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
FrozenPandaz
force-pushed
the
one-default
branch
from
September 1, 2023 16:33
0c6cb29
to
1f8a686
Compare
FrozenPandaz
changed the title
one-default
feat(misc): introduce a way to set the project name/root format for all generators
Sep 1, 2023
FrozenPandaz
force-pushed
the
one-default
branch
from
September 1, 2023 16:56
1f8a686
to
ab66c70
Compare
FrozenPandaz
force-pushed
the
one-default
branch
from
September 1, 2023 17:18
ab66c70
to
deb4e37
Compare
FrozenPandaz
force-pushed
the
one-default
branch
from
September 1, 2023 17:44
deb4e37
to
f6d20d4
Compare
barbados-clemens
approved these changes
Sep 1, 2023
FrozenPandaz
force-pushed
the
one-default
branch
from
September 1, 2023 18:58
f6d20d4
to
ed0a397
Compare
jaysoo
approved these changes
Sep 1, 2023
Failing tests are flakes |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The project name/root format has to be set for each and every generator.
Expected Behavior
The project name/root format can be set in workspaceLayout in nx.json and it will apply to all generators.
The new as-provided format is set for all new workspaces.
Related Issue(s)
Closes #18963