Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(repo): change e2e to use verdaccio executor #17347

Merged
merged 1 commit into from
Jun 7, 2023
Merged

chore(repo): change e2e to use verdaccio executor #17347

merged 1 commit into from
Jun 7, 2023

Conversation

xiongemi
Copy link
Collaborator

@xiongemi xiongemi commented Jun 1, 2023

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Jun 1, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2023 8:44pm

@nx-cloud
Copy link

nx-cloud bot commented Jun 1, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a71ec5f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 8 targets

Sent with 💌 from NxCloud.

@xiongemi xiongemi force-pushed the feat/change-e2e-verdaccio branch from 3042c06 to 8e353a1 Compare June 1, 2023 06:03
@xiongemi xiongemi force-pushed the feat/change-e2e-verdaccio branch from 8e353a1 to 32faf00 Compare June 1, 2023 15:16
@xiongemi xiongemi force-pushed the feat/change-e2e-verdaccio branch from 32faf00 to f578121 Compare June 1, 2023 22:18
@xiongemi xiongemi force-pushed the feat/change-e2e-verdaccio branch from f578121 to bfd9688 Compare June 1, 2023 22:36
@xiongemi xiongemi force-pushed the feat/change-e2e-verdaccio branch from bfd9688 to 8f2b737 Compare June 2, 2023 00:35
@xiongemi xiongemi force-pushed the feat/change-e2e-verdaccio branch from 8f2b737 to 666a799 Compare June 2, 2023 02:22
@xiongemi xiongemi marked this pull request as ready for review June 2, 2023 14:24
@xiongemi xiongemi requested review from a team, FrozenPandaz, vsavkin and JamesHenry as code owners June 2, 2023 14:24
FrozenPandaz
FrozenPandaz requested changes Jun 2, 2023
View reviewed changes
Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some cleanup

e2e/angular-core/global-setup.ts Outdated Show resolved Hide resolved
e2e/workspace-create/global-setup.ts Outdated Show resolved Hide resolved
e2e/workspace-create/global-setup.ts Outdated Show resolved Hide resolved
e2e/workspace-create/global-setup.ts Outdated Show resolved Hide resolved
nx.json Outdated Show resolved Hide resolved
e2e/angular-core/global-setup.ts Outdated Show resolved Hide resolved
@xiongemi xiongemi force-pushed the feat/change-e2e-verdaccio branch from f3ba61a to 9a33bc4 Compare June 5, 2023 20:19
@xiongemi xiongemi requested a review from meeroslav as a code owner June 5, 2023 20:19
@xiongemi xiongemi force-pushed the feat/change-e2e-verdaccio branch from 9a33bc4 to 7278bc5 Compare June 5, 2023 20:23
@xiongemi xiongemi force-pushed the feat/change-e2e-verdaccio branch from 7278bc5 to e77bbf5 Compare June 5, 2023 20:37
@xiongemi xiongemi force-pushed the feat/change-e2e-verdaccio branch from e77bbf5 to 19d3964 Compare June 5, 2023 21:22
@xiongemi xiongemi force-pushed the feat/change-e2e-verdaccio branch from 19d3964 to 2720f2f Compare June 5, 2023 21:30
@xiongemi xiongemi requested a review from FrozenPandaz June 5, 2023 22:24
FrozenPandaz
FrozenPandaz requested changes Jun 6, 2023
View reviewed changes
e2e/js/tsconfig.spec.json Outdated Show resolved Hide resolved
e2e/utils/global-setup.ts Outdated Show resolved Hide resolved
e2e/utils/global-setup.ts Outdated Show resolved Hide resolved
e2e/utils/global-setup.ts Outdated Show resolved Hide resolved
e2e/utils/global-setup.ts Outdated Show resolved Hide resolved
e2e/utils/global-teardown.ts Show resolved Hide resolved
e2e/utils/global-setup.ts Outdated Show resolved Hide resolved
@xiongemi xiongemi force-pushed the feat/change-e2e-verdaccio branch from 2720f2f to acda91c Compare June 6, 2023 19:27
@xiongemi xiongemi force-pushed the feat/change-e2e-verdaccio branch from acda91c to a71ec5f Compare June 6, 2023 20:41
@FrozenPandaz FrozenPandaz merged commit 075ac25 into master Jun 7, 2023
@FrozenPandaz FrozenPandaz deleted the feat/change-e2e-verdaccio branch June 7, 2023 16:26
juristr pushed a commit to juristr/nx that referenced this pull request Jun 7, 2023
@xiongemi @juristr
chore(repo): change e2e to use verdaccio executor (nrwl#17347)
820ab98
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@barbados-clemens barbados-clemens barbados-clemens approved these changes

@FrozenPandaz FrozenPandaz FrozenPandaz approved these changes

@vsavkin vsavkin Awaiting requested review from vsavkin vsavkin is a code owner

@JamesHenry JamesHenry Awaiting requested review from JamesHenry JamesHenry is a code owner

@Coly010 Coly010 Awaiting requested review from Coly010 Coly010 was automatically assigned from nrwl/nx-angular-reviewers

@AgentEnder AgentEnder Awaiting requested review from AgentEnder AgentEnder is a code owner

@jaysoo jaysoo Awaiting requested review from jaysoo jaysoo is a code owner

@meeroslav meeroslav Awaiting requested review from meeroslav meeroslav is a code owner

@mandarini mandarini Awaiting requested review from mandarini mandarini is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xiongemi @mandarini @FrozenPandaz @barbados-clemens