Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(react): improve react e2e tests speed #15997

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

xiongemi
Copy link
Collaborator

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Mar 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2023 3:14pm

Copy link
Contributor

@barbados-clemens barbados-clemens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small name change so we know which projects we are looking at in the logs.

e2e/react-extensions/jest.config.ts Outdated Show resolved Hide resolved
@meeroslav meeroslav force-pushed the chore/improve-react-ci-tests-speed branch from fb752ad to 535bb22 Compare April 6, 2023 11:33
Copy link
Contributor

@meeroslav meeroslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have rebased the repo, so the issue with e2e-react should no longer appear.

Unfortunately latest master also brings another bug fixed in #16152

@FrozenPandaz FrozenPandaz merged commit 5f86929 into master Apr 14, 2023
peppoasap pushed a commit to peppoasap/nx that referenced this pull request Apr 18, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023
@xiongemi xiongemi deleted the chore/improve-react-ci-tests-speed branch April 25, 2023 16:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants