-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(angular): export component generator #10883
fix(angular): export component generator #10883
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
@leosvelperez Just wanted to make sure my concerns are understood. This fixes Nx v14. We are unable to use Nx 14, we MUST use Nx 13. Our need was not to use Angular 13 (in fact, we would prefer to use a newer version)...the problem we faced is that some of our projects are Ionic-Angular projects. Ionic requires @nxtend for Ionic and Capacitor support in an Nx monorepo. The latest versions of @nxtend only work with Nx up to 13.10, and do not work with Nx 14 (as I understand it, there were some major changes in how addons/plugins work with Nx 14, which I suspect is what broke @nxtend). We spent over a week trying to get @nxtend working in an Nx 14 repo, and failed. We finally managed to get it working in an Nx 13 repo, when the versions of angular, nx, and nxtend were all aligned in a particular way (we have to use very specific versions of each). We finally managed to get that working, and then ran into this very simple issue that has limited our ability to leverage workspace generators the way we had intended to. You have merged this into Nx 14, and stated that we could use Angular 13 with Nx 14 in a comment on my PR. That does not actually address our problem, though...we CANNOT use Nx 14, and our need is specifically to be able to use Ionic, as well as whatever version of Angular is supported by the versions of Ionic and @nxtend we MUST use in order to get our Nx monorepo working for our use case. Is there any way we can either get this change included in an new version of Nx 13, or re-open my PR so that we can get my PR merged into the Nx 13.10.x branch so a new minor version of that could be released with the fix? |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
The component generator is not exported from the
@nrwl/angular
package.Expected Behavior
The component generator is exported from the
@nrwl/angular
package.Related Issue(s)
Fixes #10861
Fixes #10873