Skip to content

Commit

Permalink
fix(js): fix swc version warning (#24034)
Browse files Browse the repository at this point in the history
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->
npm warnings:
```
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: @swc-node/core@1.13.1
npm WARN Found: @swc/core@1.3.107
npm WARN node_modules/@swc/core
npm WARN   dev @swc/core@"~1.3.85" from the root project
npm WARN   3 more (@swc-node/register, nx, ts-node)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer @swc/core@">= 1.4.13" from @swc-node/core@1.13.1
npm WARN node_modules/@swc-node/register/node_modules/@swc-node/core
npm WARN   @swc-node/core@"^1.12.0" from @swc-node/register@1.8.0
npm WARN   node_modules/@swc-node/register
npm WARN 
npm WARN Conflicting peer dependency: @swc/core@1.5.7
npm WARN node_modules/@swc/core
npm WARN   peer @swc/core@">= 1.4.13" from @swc-node/core@1.13.1
npm WARN   node_modules/@swc-node/register/node_modules/@swc-node/core
npm WARN     @swc-node/core@"^1.12.0" from @swc-node/register@1.8.0
npm WARN     node_modules/@swc-node/register
```

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #23688
  • Loading branch information
xiongemi authored May 27, 2024
1 parent 8403f03 commit a6e23c1
Show file tree
Hide file tree
Showing 8 changed files with 355 additions and 346 deletions.
8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -102,10 +102,11 @@
"@supabase/supabase-js": "^2.26.0",
"@svgr/rollup": "^8.1.0",
"@svgr/webpack": "^8.0.1",
"@swc-node/register": "1.8.0",
"@swc-node/register": "~1.9.1",
"@swc/cli": "0.3.12",
"@swc/core": "^1.3.85",
"@swc/jest": "^0.2.20",
"@swc/core": "~1.5.7",
"@swc/helpers": "~0.5.11",
"@swc/jest": "~0.2.36",
"@testing-library/react": "15.0.6",
"@types/cytoscape": "^3.18.2",
"@types/detect-port": "^1.3.2",
Expand Down Expand Up @@ -311,7 +312,6 @@
"@markdoc/markdoc": "0.2.2",
"@monaco-editor/react": "^4.4.6",
"@napi-rs/canvas": "^0.1.19",
"@swc/helpers": "~0.5.2",
"@tailwindcss/aspect-ratio": "^0.4.2",
"@tailwindcss/forms": "^0.5.7",
"@tailwindcss/typography": "0.5.7",
Expand Down
9 changes: 9 additions & 0 deletions packages/jest/migrations.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,15 @@
"alwaysAddToPackageJson": false
}
}
},
"19.2.0": {
"version": "19.2.0-beta.0",
"packages": {
"@swc/jest": {
"version": "~0.2.36",
"alwaysAddToPackageJson": false
}
}
}
}
}
2 changes: 1 addition & 1 deletion packages/jest/src/utils/versions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ export const babelJestVersion = '^29.4.1';
export const jestTypesVersion = '^29.4.0';
export const tsJestVersion = '^29.1.0';
export const tslibVersion = '^2.3.0';
export const swcJestVersion = '0.2.20';
export const swcJestVersion = '~0.2.36';
export const typesNodeVersion = '18.16.9';
export const tsNodeVersion = '10.9.1';
17 changes: 17 additions & 0 deletions packages/js/migrations.json
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,23 @@
"alwaysAddToPackageJson": false
}
}
},
"19.2.0": {
"version": "19.2.0-beta.0",
"packages": {
"@swc/core": {
"version": "~1.5.7",
"alwaysAddToPackageJson": false
},
"@swc/helpers": {
"version": "~0.5.11",
"alwaysAddToPackageJson": false
},
"@swc-node/register": {
"version": "~1.9.1",
"alwaysAddToPackageJson": false
}
}
}
}
}
6 changes: 3 additions & 3 deletions packages/js/src/utils/versions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ export const nxVersion = require('../../package.json').version;
export const esbuildVersion = '^0.19.2';
export const prettierVersion = '^2.6.2';
export const swcCliVersion = '~0.3.12';
export const swcCoreVersion = '~1.3.85';
export const swcHelpersVersion = '~0.5.2';
export const swcNodeVersion = '~1.8.0';
export const swcCoreVersion = '~1.5.7';
export const swcHelpersVersion = '~0.5.11';
export const swcNodeVersion = '~1.9.1';
export const tsLibVersion = '^2.3.0';
export const typesNodeVersion = '18.16.9';
export const verdaccioVersion = '^5.0.4';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,9 @@ exports[`@nx/storybook:configuration for Storybook v7 dependencies should add an
"@storybook/jest": "^0.2.3",
"@storybook/test-runner": "^0.13.0",
"@storybook/testing-library": "^0.2.2",
"@swc-node/register": "~1.8.0",
"@swc/core": "~1.3.85",
"@swc/helpers": "~0.5.2",
"@swc-node/register": "~1.9.1",
"@swc/core": "~1.5.7",
"@swc/helpers": "~0.5.11",
"@types/jest": "^29.4.0",
"@types/node": "18.16.9",
"@typescript-eslint/eslint-plugin": "^7.3.0",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -178,9 +178,9 @@ exports[`lib should add vue, vite and vitest to package.json 1`] = `
"@nx/vite": "0.0.1",
"@nx/vue": "0.0.1",
"@nx/web": "0.0.1",
"@swc-node/register": "~1.8.0",
"@swc/core": "~1.3.85",
"@swc/helpers": "~0.5.2",
"@swc-node/register": "~1.9.1",
"@swc/core": "~1.5.7",
"@swc/helpers": "~0.5.11",
"@typescript-eslint/eslint-plugin": "^7.3.0",
"@typescript-eslint/parser": "^7.3.0",
"@vitejs/plugin-vue": "^4.5.0",
Expand Down
647 changes: 315 additions & 332 deletions pnpm-lock.yaml

Large diffs are not rendered by default.

0 comments on commit a6e23c1

Please sign in to comment.