fix(js): correctly build library with workspace dependencies (#12884)

nrwl · Oct 28, 2022 · 2cddd68 · 2cddd68 · vercel · Oct 28, 2022
1 parent d8dc205
commit 2cddd68
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/js/src/utils/check-dependencies.ts b/packages/js/src/utils/check-dependencies.ts
@@ -19,8 +19,7 @@ export function checkDependencies(
     context.root,
     context.projectName,
     context.targetName,
-    context.configurationName,
-    true
+    context.configurationName
   );
   const projectRoot = target.data.root;
 

diff --git a/packages/workspace/src/utilities/buildable-libs-utils.ts b/packages/workspace/src/utilities/buildable-libs-utils.ts
@@ -137,7 +137,8 @@ function collectDependencies(
         return;
 
       acc.push({ name: dependency.target, isTopLevel: areTopLevelDeps });
-      if (!shallow) {
+      const isInternalTarget = projGraph.nodes[dependency.target];
+      if (!shallow && isInternalTarget) {
         collectDependencies(dependency.target, projGraph, acc, shallow, false);
       }
     }