Skip to content

Commit

Permalink
fix(js): mark importPath option as important since it is required for…
Browse files Browse the repository at this point in the history
… publishable libs (#17509)
  • Loading branch information
jaysoo authored Jun 9, 2023
1 parent 8dcbd84 commit 20359e7
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 8 deletions.
9 changes: 5 additions & 4 deletions docs/generated/packages/js/generators/library.json
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,6 @@
"description": "The test environment to use if unitTestRunner is set to jest.",
"default": "jsdom"
},
"importPath": {
"type": "string",
"description": "The library name used to import it, like @myorg/my-awesome-lib."
},
"pascalCaseFiles": {
"type": "boolean",
"description": "Use pascal case file names.",
Expand All @@ -85,6 +81,11 @@
"description": "Generate a publishable library.",
"x-priority": "important"
},
"importPath": {
"type": "string",
"description": "The library name used to import it, like @myorg/my-awesome-lib. Required for publishable library.",
"x-priority": "important"
},
"buildable": {
"type": "boolean",
"default": true,
Expand Down
9 changes: 5 additions & 4 deletions packages/js/src/generators/library/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,6 @@
"description": "The test environment to use if unitTestRunner is set to jest.",
"default": "jsdom"
},
"importPath": {
"type": "string",
"description": "The library name used to import it, like @myorg/my-awesome-lib."
},
"pascalCaseFiles": {
"type": "boolean",
"description": "Use pascal case file names.",
Expand All @@ -85,6 +81,11 @@
"description": "Generate a publishable library.",
"x-priority": "important"
},
"importPath": {
"type": "string",
"description": "The library name used to import it, like @myorg/my-awesome-lib. Required for publishable library.",
"x-priority": "important"
},
"buildable": {
"type": "boolean",
"default": true,
Expand Down

1 comment on commit 20359e7

@vercel
Copy link

@vercel vercel bot commented on 20359e7 Jun 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

nx-dev – ./

nx-five.vercel.app
nx-dev-nrwl.vercel.app
nx.dev
nx-dev-git-master-nrwl.vercel.app

Please sign in to comment.