-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deno): @nrwl/deno MVP #138
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barbados-clemens
force-pushed
the
feat/experimental-deno
branch
3 times, most recently
from
February 9, 2023 17:17
6489a65
to
79a9e2a
Compare
nartc
reviewed
Feb 9, 2023
barbados-clemens
force-pushed
the
feat/experimental-deno
branch
from
February 9, 2023 19:28
79a9e2a
to
e3e4719
Compare
WIP WIP library gen chau wip wip graph wip more deno wip: linter schema wip: test schema add vscode settings to enable deno editor support use deno.json more schema changes WIP: e2e tests wip: e2e tests deno e2e tests wip migrate graph support promise all file processors clean up testing schema options clean up lint schema options update deno readme add publish config add deno vscode settings path update graph processor (haven't tested might have broken) clean up fix add paths maybe ready?
barbados-clemens
force-pushed
the
feat/experimental-deno
branch
from
February 9, 2023 19:31
e3e4719
to
7beca1a
Compare
nartc
reviewed
Feb 9, 2023
barbados-clemens
force-pushed
the
feat/experimental-deno
branch
from
February 9, 2023 21:41
9fde27e
to
82eff7b
Compare
barbados-clemens
force-pushed
the
feat/experimental-deno
branch
from
February 9, 2023 22:02
82eff7b
to
2f1c8a6
Compare
nartc
approved these changes
Feb 10, 2023
barbados-clemens
changed the title
[WIP]: feat(deno): @nrwl/deno MVP
feat(deno): @nrwl/deno MVP
Feb 10, 2023
AgentEnder
reviewed
Feb 10, 2023
@@ -0,0 +1,3 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Use writeJson
instead of ejs for this file
AgentEnder
approved these changes
Feb 10, 2023
barbados-clemens
force-pushed
the
feat/experimental-deno
branch
from
February 10, 2023 20:52
9286c39
to
723678a
Compare
FrozenPandaz
approved these changes
Feb 10, 2023
packages/deno/executors.json
Outdated
{ | ||
"$schema": "http://json-schema.org/schema", | ||
"executors": { | ||
"build": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename this to bundle
so that it matches the deno command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add @nrwl/deno plugin with the capabilities:
using e2e tests to validate plugin.
PR also includes updating the workspace/fixing issues with other plugins that came from updating the workspace as well.