Apply compile flags consistently #22
Conversation
|
Should |
Sort some of the Makefile contents. Add $(NWMKTEMPOBJS) for consistency, and add nwmktemp to the clean rules. Remove gitversion.o from $(FILES) and $(SRCS). Both were likely meant to contain gitversion.c, not .o. The existence in $(FILES) generates errors when building doc.dvi. The existence in $(SRCS) creates an undesired empty gitversion.c/.o during `make boot`; add gitversion.c as a special file to clobber instead.
Since all three may contain spaces, quote them when passing to a sub-make. Remove ICONC, ICONT, and BIN from the contrib Makefiles since no leaf Makefile currently makes use of them, and installation step 5 does not mention them.
|
I've added a mention of CFLAGS and a couple other variables to the installation steps (latest commit), rebased on your latest commit, and fixed a couple issues with gitversion.c/.o. |
|
Thanks! I blew my noweb budget yesterday, but I'll hope to get back to this one soon. |
|
In the following line, why are the Icon assignments quoted but the LIB and BIN assignments not quoted? |
I think it was primarily for attaching flags to the Icon commands (the |
|
OK, let's leave it as is, then. |
Another piece of #10:
$(LDFLAGS)when linking, add a missing$(CFLAGS)to contrib/norman/numarkup, move flags from$(CC)to$(CFLAGS).$(CFLAGS)causes the fakepretty build to fail. Fix up those warnings/errors, and sort a few parts of the Makefile so that fakepretty (and nwmktemp) is on par with the other targets in src/c.