Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement VISCA over IP and Panasonic PTZ actions #340

Draft
wants to merge 6 commits into
base: release51
Choose a base branch
from

Conversation

ianshade
Copy link
Contributor

@ianshade ianshade commented Jul 5, 2024

About the Contributor

This PR is opened on behalf of TV 2 Norge.

Type of Contribution

This is a:

Feature (including some Code improvements)

Current Behavior

  • No Actions on Panasonic PTZ integration
  • No VISCA over IP integration at all

New Behavior

  • PTZ actions are added to the Panasonic PTZ integration
  • VISCA over IP integration is added, featuring just PTZ actions

Testing Instructions

Other Information

It's a draft!
VISCA over IP integration is based on a fixed and refactored version of https://github.com/nrkno/sofie-sony-visca-connection

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 59.94865% with 312 lines in your changes missing coverage. Please review.

Project coverage is 55.59%. Comparing base (f6a3609) to head (2fd1629).

Files Patch % Lines
.../integrations/viscaOverIP/connection/lib/socket.ts 4.13% 116 Missing ⚠️
...ate-resolver/src/integrations/viscaOverIP/index.ts 10.65% 109 Missing ⚠️
...te-resolver/src/integrations/panasonicPTZ/index.ts 8.77% 52 Missing ⚠️
...r/src/integrations/viscaOverIP/connection/visca.ts 13.63% 19 Missing ⚠️
...solver/src/integrations/panasonicPTZ/connection.ts 80.00% 3 Missing ⚠️
...nnection/commands/control/resetSeqNumberCommand.ts 50.00% 2 Missing ⚠️
...ection/commands/inquiry/focusModeInquiryCommand.ts 66.66% 2 Missing ⚠️
...on/commands/inquiry/focusPositionInquiryCommand.ts 71.42% 2 Missing ⚠️
.../commands/inquiry/panTiltPositionInquiryCommand.ts 75.00% 2 Missing ⚠️
...ion/commands/inquiry/zoomPositionInquiryCommand.ts 71.42% 2 Missing ⚠️
... and 2 more
Additional details and impacted files
@@              Coverage Diff              @@
##           release51     #340      +/-   ##
=============================================
+ Coverage      55.39%   55.59%   +0.20%     
=============================================
  Files            129      156      +27     
  Lines          10057    10662     +605     
  Branches        2491     2507      +16     
=============================================
+ Hits            5571     5928     +357     
- Misses          4108     4732     +624     
+ Partials         378        2     -376     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jstarpl jstarpl added the contribution from TV 2 Norge Contributions sponsored by TV 2 Norge (tv2.no) label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution from TV 2 Norge Contributions sponsored by TV 2 Norge (tv2.no)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants