Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: exclude pieces from part keepalive #1343

Draft
wants to merge 3 commits into
base: release52
Choose a base branch
from

Conversation

Julusian
Copy link
Member

About the Contributor

This pull request is posted on behalf of the BBC

Type of Contribution

This is a: Feature

Current Behavior

All pieces from a part are included in the keepalive region of a part during a transition. This can lead to unintended effects, such as graphics starting their out animation too late.

New Behavior

Each piece can opt out of being included in this keepalive region.

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

This adds some framework and initial tests for the timeline generation, focusing specifically on how the part and piece groups are arranged.

Affected areas

This PR affects the timeline generation.

Time Frame

Other Information

When reviewing, I would recommend reviewing the first commit of pure refactoring before the rest of the changes

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 98.80478% with 3 lines in your changes missing coverage. Please review.

Project coverage is 56.49%. Comparing base (83c11bf) to head (940ef20).
Report is 53 commits behind head on release52.

Files with missing lines Patch % Lines
packages/job-worker/src/playout/timeline/part.ts 97.93% 2 Missing ⚠️
...ackages/job-worker/src/playout/timeline/rundown.ts 99.31% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           release52    #1343      +/-   ##
=============================================
+ Coverage      56.25%   56.49%   +0.23%     
=============================================
  Files            399      401       +2     
  Lines          71164    71993     +829     
  Branches        4495     4147     -348     
=============================================
+ Hits           40035    40672     +637     
- Misses         31028    31233     +205     
+ Partials         101       88      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Julusian Julusian added the Contribution from BBC Contributions sponsored by BBC (bbc.co.uk) label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution from BBC Contributions sponsored by BBC (bbc.co.uk)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant