feat: exclude pieces from part keepalive #1343
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the Contributor
This pull request is posted on behalf of the BBC
Type of Contribution
This is a: Feature
Current Behavior
All pieces from a part are included in the keepalive region of a part during a transition. This can lead to unintended effects, such as graphics starting their out animation too late.
New Behavior
Each piece can opt out of being included in this keepalive region.
Testing
This adds some framework and initial tests for the timeline generation, focusing specifically on how the part and piece groups are arranged.
Affected areas
This PR affects the timeline generation.
Time Frame
Other Information
When reviewing, I would recommend reviewing the first commit of pure refactoring before the rest of the changes
Status