chore: some minor changes

[Julusian]

About the Contributor

This pull request is posted on behalf of the BBC

Type of Contribution

This is a: Misc cleanup

New Behavior

Following the merge of a heap of large PRs, this PR contains a few tweaks that were missed in their respective PRs, or is the result of any conflicts

I believe the Meteor.absoluteUrl are the result of having issues when experimenting with running under a subdirectory. While not entirely necessary to merge, the code does nothing for us, and Sofie doesn't work when run under a subdirectory, so that isn't a valid scenario that needs to be supported.

The error handler change; was a DX improvement, to make the server logs more readable when there are react deprecations being logged.

The add studio settings allowHold & allowPieceDirectPlay migration is no longer correct, following #1332.

The Ensure CoreSystem.settingsWithOverrides is valid was added following a deployment issue where sofie got into a bad state, and I forgot to add it to its original PR.

Testing

• I have added one or more unit tests for this PR
• I have updated the relevant unit tests
• No unit test changes are needed for this PR

Affected areas

Time Frame

Other Information

Status

• PR is ready to be reviewed.
• The functionality has been tested by the author.
• Relevant unit tests has been added / updated.
• Relevant documentation (code comments, system documentation) has been added / updated.

[codecov]

Codecov Report

Attention: Patch coverage is 40.00000% with 36 lines in your changes missing coverage. Please review.

Project coverage is 56.25%. Comparing base (fdf019b) to head (83c11bf).
Report is 3 commits behind head on release52.

Files with missing lines	Patch %	Lines
meteor/server/migration/X_X_X.ts	40.00%	36 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##           release52    #1341      +/-   ##
=============================================
- Coverage      56.26%   56.25%   -0.01%     
=============================================
  Files            399      399              
  Lines          71141    71164      +23     
  Branches        4482     4495      +13     
=============================================
+ Hits           40027    40035       +8     
- Misses         30983    31028      +45     
+ Partials         131      101      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nytamin]

Note: I had to revert the parts removing Meteor.absoluteUrl from this PR post-merge, as the removal caused the client ddp-websocket connection to connect to the wrong url (it tried to connect to ws://localhost/websocket:3005 instead of ws://localhost/websocket:3000) .