Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the Contributor
This pull request is posted on behalf of the NRK.
Type of Contribution
This is a:
Code improvement
Current Behavior
When starting up in development mode, there are a lot of warnings in the console:
New Behavior
No warnings, after I refactored the .scss files:
calc()
Testing
Affected areas
(If done improperly) This PR affects the GUI of Sofie.
Time Frame
Not urgent, but we would like to get this merged into the in-development release asap, to improve developer experience.
Other Information
Status
"utf-8-validate" requires latest node-gyp-build