Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 52 #1300

Open
wants to merge 319 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
319 commits
Select commit Hold shift + click to select a range
e495db2
chore: remove some unnecessary uses of EditAttribute (#1254)
Julusian Sep 2, 2024
0d1b890
Merge remote-tracking branch 'origin/release51' into feat/quickLoop
ianshade Sep 2, 2024
d5c2cad
fix: update mos-connection dependency (SOFIE-3006) (#1251)
nytamin Sep 5, 2024
497bd3d
Merge branch 'release51' into release52
Julusian Sep 6, 2024
503e622
Merge branch 'release52' into feat/vite-ui-bundler2
Julusian Sep 6, 2024
8e16b94
fix: rework versionExtended flow to be done via meteor runtime_config
Julusian Sep 6, 2024
5844a0c
Merge pull request #1230 from nrkno/feat/vite-ui-bundler2
Julusian Sep 9, 2024
ea30e05
chore: update to new nightly of TSR
jstarpl Sep 9, 2024
f94db28
fix: removing parts/segments with quickloop markers
mint-dewit Sep 18, 2024
45659c2
Merge remote-tracking branch 'origin/release51' into release52
jstarpl Sep 18, 2024
e8826c1
fix: no quickloop autotake on parts that were running for a long time
mint-dewit Sep 19, 2024
6950fea
fix: quickloop rundown reset
mint-dewit Sep 19, 2024
43e0564
fix: asyncapi-generator-react-sdk patch
jstarpl Sep 19, 2024
479f696
Merge branch 'release51' into release52
jstarpl Sep 19, 2024
02be272
feat: allow ab sessions to declare themselves as 'globally unique'
Julusian Sep 17, 2024
f4e61fa
fix: ensure ab sessions get reordered when adlibbing a fixed duration…
Julusian Sep 17, 2024
250b5d7
fix: ensure pieces don't claim to have durations when their end has n…
Julusian Sep 18, 2024
a19ab10
Merge remote-tracking branch 'nrk/release52' into feat/quickLoop
mint-dewit Sep 24, 2024
6afbb53
chore: lint
mint-dewit Sep 24, 2024
ce68543
fix: make openMediaHotStandby option pr subdevice, and rename from ho…
olzzon Sep 24, 2024
1d87ef1
chore: remove file that got duplicated in merge
mint-dewit Sep 24, 2024
bf1719d
chore: remove local patch of `@asyncapi/generator-react-sdk`
jstarpl Sep 25, 2024
506b920
chore: remove a extraneous import in meteor server code
jstarpl Sep 25, 2024
cdb6c90
Merge pull request #1261 from bbc/upstream/SUPERFLY-5-ab-sessions-acr…
nytamin Sep 25, 2024
e962e5e
chore: Eslint server in vscode doesn't work because it can't find the…
jstarpl Sep 26, 2024
8c154af
Merge pull request #1112 from bbc/feat/quickLoop
jstarpl Sep 26, 2024
298c0fd
fix: In kiosk mode, rundown page gets stalled if rundown is removed w…
olzzon Sep 27, 2024
e839b97
feat: routeset config defined in blueprints
olzzon Sep 23, 2024
92b9e85
fix: go to renderDataMissing() is rundown is not found - and revert p…
olzzon Sep 30, 2024
7c4f1ae
fix: re-implement setReady to false in useSubscriptionIfEnabled()
olzzon Sep 30, 2024
e560a4c
Merge branch 'release51' into release52
jstarpl Sep 30, 2024
7438176
fix: patch `timecode` dependency to work once packaged with vite
Julusian Oct 1, 2024
88fc61d
fix: missing font once packaged with vite
Julusian Oct 1, 2024
c7c1d10
fix: koa not serving app for non-root url
Julusian Oct 1, 2024
5dc59ed
fix: some styling bugs
Julusian Oct 1, 2024
339f8cb
fix: webui eslint failure
Julusian Oct 2, 2024
81bf9cb
feat: rework user permissions in the ui to use a react context
Julusian Sep 20, 2024
bb4c22b
fix: handle durations of onRundownChange infinites correctly when spa…
Julusian Oct 2, 2024
101b369
Merge pull request #1273 from bbc/upstream/r52-ui-bugs
jstarpl Oct 3, 2024
f4e1108
Merge pull request #1269 from bbc/fix/ui-no-return-to-rundown-if-deleted
jstarpl Oct 3, 2024
9aaa2dd
feat: add segment timing countdownType
Julusian Oct 3, 2024
22b4a3c
fix: track segmentStartedPlayback against `SegmentPlayoutId` instead …
Julusian Oct 3, 2024
ee3e569
Rework playout connection management (sofie 1152) (#1271)
mint-dewit Oct 8, 2024
985f4f4
Merge pull request #1276 from bbc/upstream/fix-on-change-infinites-in…
nytamin Oct 8, 2024
e2fe446
fix: dis-/en-able heartbeat when openMediaHotStandby
olzzon Oct 8, 2024
752a30a
fix: review comments
Julusian Oct 8, 2024
954a05a
fix: implement editor ui
Julusian Oct 8, 2024
0bd2d4d
chore: lint
Julusian Oct 8, 2024
6849552
chore: review comments
Julusian Oct 8, 2024
30c2bdd
chore: split `SystemStatus.tsx` into multiple files
Julusian Oct 8, 2024
b625b33
chore: convert `DeviceItem` to functional component
Julusian Oct 8, 2024
1729c7d
chore: refactor `SystemStatus` to be functional
Julusian Oct 8, 2024
b6a7f90
Merge pull request #1262 from bbc/upstream/routeset-config-defined-in…
nytamin Oct 9, 2024
685364d
feat: config package manager from blueprints
olzzon Sep 23, 2024
5120882
feat: routeset controlled ab player assignment
olzzon Sep 27, 2024
5ef7c34
fix: avoid excessive applyAndValidateOverrides
Julusian Oct 9, 2024
e8e1a28
chore: preempt review comments
Julusian Oct 9, 2024
1b5a5ce
Updated to revert separate templateAdLib array, client now uses a pub…
Oct 9, 2024
0b744f1
Add explicit actionOptions property to adLibAction
Oct 9, 2024
174699b
chore(.vscode/settings): add webui to eslint workingDirectories
jstarpl Oct 9, 2024
d60dfc4
fix(NotificationPopUp): buttons have no margins
jstarpl Oct 9, 2024
cb880eb
Consolidate validation method, updates from Julusian comments
Oct 9, 2024
3defab2
chore: reuse PlayerId
Julusian Oct 10, 2024
f11829e
chore: review comments
Julusian Oct 10, 2024
2f2f3b4
chore: type error
Julusian Oct 10, 2024
52ede26
fix: reset segments when added to an active loop
mint-dewit Oct 7, 2024
425d229
fix(ui): timing in quickloop
mint-dewit Oct 7, 2024
5c78889
fix: rundown reset resets quickloop markers
mint-dewit Oct 8, 2024
77cc59b
chore: optimise getSegmentsBetweenMarkers
mint-dewit Oct 10, 2024
4e3af33
Merge pull request #1272 from bbc/upstream/routeset-ab-player-control
nytamin Oct 14, 2024
99533aa
fix: ensure timeline is regenerated after switching routeset affectin…
Julusian Oct 14, 2024
ad8e1d6
Merge pull request #1285 from bbc/upstream/fix-regenerate-timeline-af…
jstarpl Oct 14, 2024
91d2b48
Merge pull request #1278 from bbc/upstream/rework-ui-permissions-flow
jstarpl Oct 15, 2024
1ccd814
Merge branch 'release51' into release52
jstarpl Oct 15, 2024
5987326
Merge pull request #1263 from bbc/upstream/config-package-manager-fro…
nytamin Oct 16, 2024
4a3f6c1
chore: type fix after merge
nytamin Oct 16, 2024
132ebc0
chore: fix unit test and lint
nytamin Oct 17, 2024
3fd9716
chore: revert countdown in top bar to part time
mint-dewit Oct 17, 2024
191353f
chore: split job-worker context.ts into multiple files
Julusian Oct 17, 2024
4a1c882
feat: reimplement model `switchRouteSet` to perform operation on `con…
Julusian Oct 17, 2024
216bcab
chore: swap segment and part countdown
mint-dewit Oct 18, 2024
082b1d8
fix: type mismatch and confusing ui for enabling/disabling ab players
Julusian Oct 14, 2024
a498d90
fix: use segment budget duration for segment duration counter (#15)
Julusian Oct 18, 2024
ed82e6b
fix: remove unused meteor ui packages
Julusian Oct 15, 2024
e69a4fc
feat: processIngestData & userEditOperations
Julusian Oct 18, 2024
ca11fc8
Merge pull request #1292 from bbc/upstream/remove-meteor-packages
nytamin Oct 21, 2024
5bb60d0
chore: tidy
Julusian Oct 21, 2024
9be51e4
chore: jsx component
Julusian Oct 21, 2024
dfc7c5e
chore: fix tests
Julusian Oct 21, 2024
c6df21a
Merge remote-tracking branch 'upstream/release52' into upstream/segme…
Julusian Oct 22, 2024
9efddf5
chore: fix tests
Julusian Oct 22, 2024
df0dc95
fix: prompter skipped pieces
mint-dewit Oct 22, 2024
e26a3d2
Merge pull request #1296 from bbc/fix/prompter-skips-script-pieces
jstarpl Oct 23, 2024
1dfdaad
chore: add playlist timings to LSG
mint-dewit Oct 14, 2024
a6e9a9b
Merge pull request #1283 from bbc/upstream/fix-quickloop-timers
jstarpl Oct 23, 2024
a1d1f42
chore: only count down to segment time if available
mint-dewit Oct 24, 2024
9c308e5
chore: rename to expectedDurationMs
mint-dewit Oct 24, 2024
fad8334
chore: rename
mint-dewit Oct 24, 2024
6ef01f1
chore: fix tests
mint-dewit Oct 24, 2024
f8a1d75
Merge pull request #1298 from bbc/upstream/chore-add-lsg-playlist-timing
jstarpl Oct 24, 2024
c228251
feat: list routesets from blueprints adlib action
mint-dewit Oct 24, 2024
56f1399
Merge remote-tracking branch 'upstream/release52' into upstream/segme…
Julusian Oct 24, 2024
474e0d3
fix: restore test
Julusian Oct 24, 2024
817f9a0
chore: review comments
Julusian Oct 24, 2024
c5b833d
feat: add `notes` to `RundownPlaylist` and pipe notes from blueprints…
Julusian Oct 21, 2024
d9fafe0
feat: Server-side notifications #1193
Julusian Oct 24, 2024
3b4cdda
fix: prefer field_order from package info stream over deepscan
Julusian Oct 24, 2024
3818de8
Merge pull request #1301 from bbc/upstream/feat-list-routesets-in-adl…
jstarpl Oct 24, 2024
549f544
Merge pull request #1277 from bbc/upstream/segment-timing
jstarpl Oct 28, 2024
3a66e93
chore: update comments
jstarpl Oct 28, 2024
1795ea9
Merge branch 'release51' into release52
jstarpl Oct 28, 2024
d2aa933
Merge pull request #1291 from bbc/upstream/fix-switchrouteset-updatin…
jstarpl Oct 29, 2024
799ab71
Merge pull request #1295 from bbc/upstream/playlist-notes
jstarpl Oct 29, 2024
c295ad6
Merge branch 'upstream/release52' into upstream/server-side-notificat…
Julusian Oct 29, 2024
aefc95d
Merge branch 'upstream/release52' into upstream/process-ingest-data2
Julusian Oct 29, 2024
f1f77fa
feat: quickloop improvements
Julusian Oct 24, 2024
3daed38
Further updates mainly to improve logging and code comments
Oct 30, 2024
9a3e400
chore: add user option to upload and ingest ingestData from snapshot
nytamin Oct 31, 2024
91e6a40
feat: meteor 2.16
Julusian Oct 31, 2024
c9e739d
fix: remove unused `rundownIds` parameter from `MeteorPubSub.uiPartIn…
Julusian Nov 1, 2024
005a0e5
fix: action triggers editor not showing previews
Julusian Nov 1, 2024
c2a6522
feat: convert action-triggers computation to async
Julusian Nov 1, 2024
874e85c
fix: RundownView shows spinner when unMOSing a Rundown from a Playlist
jstarpl Nov 4, 2024
a9daca2
fix: Unable to clear infinites
Julusian Nov 4, 2024
d798c7c
chore: replace contextTypes with modern alternatives
Julusian Nov 4, 2024
c593560
fix: publications not becoming ready when returning null
Julusian Nov 6, 2024
89d7eca
Updated to add hidden property to IBlueprintAdLibPiece and IBlueprint…
Nov 6, 2024
a876c6d
chore: cleanup unused keyboardmap and meteor settings
Julusian Nov 7, 2024
f3244b7
Merge branch 'release52' into feat/adlib-action-options
Nov 13, 2024
e245b15
Merge branch 'release52' into feat/blueprint-config-validation
Nov 13, 2024
50bc344
Merge branch 'release52' into feat/templateAdlibs
Nov 13, 2024
3799e61
Merge pull request #1226 from evs-broadcast/feat/adlib-action-options
jstarpl Nov 13, 2024
73527e0
Merge pull request #1221 from evs-broadcast/feat/templateAdlibs
jstarpl Nov 13, 2024
76b8cbd
chore(AdLibPanel): simplify
jstarpl Nov 13, 2024
175b5ff
fix(AdLibPanel): support hidden on AdLibPieces
jstarpl Nov 13, 2024
db9bd7d
Merge pull request #1319 from nrkno/chore/evs-hidden-adlibs
jstarpl Nov 13, 2024
ecc1768
Merge pull request #1223 from evs-broadcast/feat/blueprint-config-val…
nytamin Nov 14, 2024
428e95d
chore: remove handling of legacy mos data import
nytamin Nov 14, 2024
5d72c14
chore: move checkForMultipleVersions into a yarn script
jstarpl Nov 15, 2024
9636051
fix: release scripts broken on Windows
jstarpl Nov 15, 2024
8c78ed2
Merge branch 'release51' into release52
jstarpl Nov 15, 2024
b0daf75
feat: option to disable HOLD & direct play (#32)
Julusian Nov 25, 2024
ea2cae1
feat: option to disable/enable buckets (#36)
olzzon Nov 20, 2024
cc866ca
Merge branch 'release51' into release52
jstarpl Nov 25, 2024
d7a216d
fix: `queuedSegmentId` ignored when taking last part of the rundown
Julusian Nov 26, 2024
89ddacf
Merge pull request #1330 from bbc/upstream/fix-queued-segment-when-on…
jstarpl Nov 26, 2024
c58d6ba
Merge pull request #1324 from bbc/upstream/fix-infinite-end-and-duration
jstarpl Nov 26, 2024
fa367ed
Merge pull request #1318 from bbc/upstream/remove-unused-keyboardmap-…
jstarpl Nov 26, 2024
a886bc4
Merge pull request #1309 from bbc/upstream/fix-action-triggers-previews
jstarpl Nov 26, 2024
193815d
fix: Device Action Studio Context gets lost, Adlib previews are unstable
jstarpl Nov 29, 2024
13f0556
chore: improve documentation
jstarpl Nov 29, 2024
02b8594
Merge pull request #1311 from nrkno/fix/sofie-3593/show-style-variant…
jstarpl Nov 29, 2024
fb50990
Merge branch 'master' into release51
jstarpl Nov 29, 2024
24aae09
Merge branch 'release51' into release52
jstarpl Nov 29, 2024
8b926ac
fix: the scss structure was reimporting colors and variable multiple …
olzzon Dec 2, 2024
1478b68
Merge pull request #1334 from nrkno/fix/sofie-3638/device-action-cont…
jstarpl Dec 4, 2024
9f9b6e7
Merge pull request #1321 from nrkno/fix/release-scripts
jstarpl Dec 4, 2024
d2a3cdf
chore(release): 1.51.4
jstarpl Dec 4, 2024
ef01346
Merge branch 'chore/upload-ingest-snapshot' into release52
nytamin Dec 5, 2024
24dccd6
chore: lint fix
nytamin Dec 5, 2024
7a5dc15
chore: fix install bug on windows
nytamin Dec 9, 2024
a96f615
chore: refactor sass to fix deprecation warnings
nytamin Dec 9, 2024
a668b44
chore: replace `meteor yarn` with `meteor npm run` to fix issue with …
nytamin Dec 9, 2024
90fb8e8
Merge pull request #1339 from nrkno/chore/deprecated-sass
nytamin Dec 9, 2024
162af01
Merge pull request #1335 from bbc/upstream/pr-over-onehundres-css-sty…
jstarpl Dec 9, 2024
fcd04da
Merge pull request #1313 from bbc/chore/replace-contextTypes
jstarpl Dec 10, 2024
6b36d5b
Merge branch 'release52' into upstream/interlaced-fix
Julusian Dec 10, 2024
57ddfde
Merge pull request #1340 from bbc/upstream/interlaced-fix
jstarpl Dec 10, 2024
6e04a7f
chore: doc and fixes after code review
nytamin Dec 10, 2024
f742fcb
Merge branch 'upstream/process-ingest-data2' into release52
nytamin Dec 10, 2024
f6d8290
chore: minor fixes after code review
nytamin Dec 10, 2024
96ec63a
Merge branch 'upstream/quickloop-improvements' into release52
nytamin Dec 10, 2024
33f53cb
chore: minor fixes after code review
nytamin Dec 10, 2024
993a696
Merge branch 'feat/pr-upstream-for-elemement-selector-for-ui' of gith…
nytamin Dec 10, 2024
20ab08d
chore: minor fixes after code review
nytamin Dec 10, 2024
3f63362
Merge branch 'upstream/action-triggers-async' into release52
nytamin Dec 10, 2024
45fa3d2
Merge branch 'upstream/studio-settings-for-features' of github.com:bb…
nytamin Dec 10, 2024
999b800
chore: fix unit test & CI
nytamin Dec 10, 2024
11ddc3a
chore: fix moar tests
nytamin Dec 10, 2024
f723c27
chore: fix unit tests & CI
nytamin Dec 10, 2024
c4365ad
Revert "chore: fix unit tests & CI"
nytamin Dec 10, 2024
a6ce734
Merge branch 'upstream/release52' into upstream/server-side-notificat…
Julusian Dec 10, 2024
8670727
feat: meteor 3.0.4
Julusian Dec 10, 2024
61b6854
feat: update meteor to 3.1 and node to 22
Julusian Nov 25, 2024
aaaa3d5
chore: improve when webui is built
Julusian Nov 19, 2024
da49fe1
chore: missing import
Julusian Dec 10, 2024
ef14c8f
feat: configure Core system/studio settings via blueprints
Julusian Nov 20, 2024
5f77a10
chore: fix lint
Julusian Dec 10, 2024
c4b8da5
feat: Sofie Core Groups with Trusted header SOFIE-95
Julusian Nov 26, 2024
4918e04
chore: update documentation
Julusian Nov 26, 2024
6b02621
chore: remove unused css
Julusian Nov 26, 2024
1e5bbc6
feat: support for http header in packagemanager
olzzon Sep 9, 2024
c7bdfe6
feat: always add `dnt=gateway` header for gateway connections
Julusian Nov 27, 2024
3f71257
Merge branch 'upstream/release52' into feat/mos-openmedia-hot-standby
Julusian Dec 10, 2024
685862b
chore: review comments
Julusian Dec 10, 2024
3d559f1
fix: unable to remove peripheralDevice
Julusian Dec 3, 2024
4c7a337
chore: fix missed security check
Julusian Dec 10, 2024
878214b
feat: configure peripheral device settings from blueprints
Julusian Dec 9, 2024
f54bd28
chore: add deprecation note
Julusian Dec 11, 2024
5a58f71
feat!: remove showstyle and studio blueprint migrations
Julusian Dec 11, 2024
11b7493
WIP
nytamin Dec 11, 2024
2095210
chore: minor docs after code review
nytamin Dec 11, 2024
8ac7b39
chore: minor docs after code review
nytamin Dec 11, 2024
49730ed
Merge branch 'upstream/meteor3' into release52
nytamin Dec 11, 2024
263a06c
Merge branch 'upstream/blueprint-configure-system-settings' into rele…
nytamin Dec 11, 2024
5d2d5bf
Merge branch 'upstream/header-based-auth' into release52
nytamin Dec 11, 2024
dd5010a
chore: fix unit test
nytamin Dec 11, 2024
0b5412a
Merge branch 'upstream/release52' into upstream/peripheral-device-set…
Julusian Dec 11, 2024
b628877
Merge branch 'upstream/release52' into upstream/server-side-notificat…
Julusian Dec 11, 2024
fdf019b
chore: fix lint
Julusian Dec 11, 2024
b66de77
Merge pull request #1336 from bbc/upstream/peripheral-device-settings…
nytamin Dec 11, 2024
83c11bf
chore: some minor changes
Julusian Dec 11, 2024
34d3f91
Merge pull request #1341 from bbc/upstream/tidying
jstarpl Dec 11, 2024
31d72ff
Merge pull request #1303 from bbc/upstream/server-side-notifications
jstarpl Dec 11, 2024
29c0800
chore: fix a typo in #getOrCategoryEntry
jstarpl Dec 11, 2024
b69478f
Merge pull request #1169 from bbc/feat/mos-openmedia-hot-standby
jstarpl Dec 11, 2024
d421e78
chore: update mos-connection
jstarpl Dec 11, 2024
847bf1c
Merge branch 'release51'
nytamin Dec 12, 2024
c1a9a02
Merge branch 'release51' into release52
nytamin Dec 12, 2024
2eafb6a
chore: fix crashing job-worker on startup
nytamin Dec 12, 2024
e6e9aa7
Partially revert "Merge pull request #1341 from bbc/upstream/tidying"…
nytamin Dec 12, 2024
ddab6df
fix: missing roboto font after scss cleanup
jstarpl Dec 12, 2024
a7d6999
fix(job-worker/playout): Hold mode doesn't work at all
jstarpl Dec 13, 2024
8292d96
fix: remove Meteor.absoluteUrl and proxy ddp through vite.
Julusian Dec 16, 2024
9903411
Merge pull request #1344 from bbc/upstream/header-auth-in-dev
nytamin Dec 16, 2024
0399c56
chore: add docs for distributed package-manager
Julusian Dec 11, 2024
44b475e
fix: package-manager publications forcing arguments
Julusian Dec 16, 2024
b9d59c2
chore: update wording
Julusian Dec 16, 2024
e9f21fb
feat: Evaluation form is optional in studio settings, with default tu…
olzzon Dec 17, 2024
315bb5e
Merge pull request #1347 from bbc/feat/option-to-disable-evaluation-form
jstarpl Dec 17, 2024
aa3332a
chore: review comments
Julusian Dec 17, 2024
e1c5105
Merge pull request #1345 from bbc/upstream/package-manager-docs-update
jstarpl Dec 17, 2024
b76691a
chore(docs): word capitalization
jstarpl Dec 17, 2024
7f1bc02
chore: fix typo
Julusian Dec 17, 2024
c6be9f5
Merge pull request #1348 from bbc/upstream/fix-typo-1347
jstarpl Dec 17, 2024
8704ff8
fix: sofie logo not showing in dev
Julusian Dec 18, 2024
c810d26
chore: convert some class react components to functional
Julusian Dec 18, 2024
8dc29c9
chore: refactor EditAttribute to hooks
Julusian Dec 18, 2024
8c5c933
chore: remove unused EditAttribute 'array' type
Julusian Dec 18, 2024
2bb0dc8
Merge pull request #1350 from bbc/upstream/fix-logo-not-showing-in-dev
jstarpl Dec 18, 2024
8a10914
chore: update tsr
jstarpl Dec 19, 2024
8f0153e
feat: move next part should respect quickloop bounds
mint-dewit Nov 4, 2024
988274d
Merge pull request #1352 from nrkno/fix/sofie-3661/broken-hold
jstarpl Jan 7, 2025
4253eea
chore(release): 1.51.5
jstarpl Jan 7, 2025
462f20f
Merge branch 'release51' into release52
jstarpl Jan 7, 2025
b87cd9f
chore: add defaults
mint-dewit Jan 7, 2025
bd3aeaa
Merge pull request #1354 from bbc/upstream/feat-move-next-in-quickloop
jstarpl Jan 7, 2025
b20b4a4
Merge pull request #1351 from bbc/upstream/convert-some-components
nytamin Jan 8, 2025
cf72b49
feat: add ignoreQuickLoop as an optional attr in the openAPI
olzzon Jan 9, 2025
cb59dd9
Merge pull request #1357 from bbc/upstream/feat-move-next-quickloop-a…
jstarpl Jan 10, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
4 changes: 1 addition & 3 deletions .github/actions/setup-meteor/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,5 @@ description: "Setup Meteor"
runs:
using: "composite"
steps:
- run: curl "https://install.meteor.com/?release=2.13.3" | sh
shell: bash
- run: meteor npm install -g yarn
- run: curl "https://install.meteor.com/?release=3.1" | sh
shell: bash
4 changes: 2 additions & 2 deletions .github/workflows/audit.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
run: |
yarn
cd meteor
meteor yarn validate:prod-dependencies
yarn validate:prod-dependencies
env:
CI: true

Expand Down Expand Up @@ -57,7 +57,7 @@ jobs:
run: |
yarn
cd meteor
meteor yarn run validate:all-dependencies
yarn run validate:all-dependencies
env:
CI: true

Expand Down
48 changes: 29 additions & 19 deletions .github/workflows/node.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
# setup zodern:types. No linters are setup, so this simply installs the packages
meteor lint

meteor yarn ci:lint
yarn ci:lint
env:
CI: true

Expand Down Expand Up @@ -85,7 +85,7 @@ jobs:
# setup zodern:types. No linters are setup, so this simply installs the packages
meteor lint

NODE_OPTIONS="--max-old-space-size=6144" meteor yarn unitci --force-exit
NODE_OPTIONS="--max-old-space-size=6144" yarn unitci --force-exit
env:
CI: true
- name: Send coverage
Expand Down Expand Up @@ -184,11 +184,18 @@ jobs:
run: |
cd meteor
yarn inject-git-hash
- name: Prepare webui for meteor build
if: steps.check-build-and-push.outputs.enable == 'true'
run: |
rm -Rf meteor/public
cp -R packages/webui/dist meteor/public
- name: Meteor Build
if: steps.check-build-and-push.outputs.enable == 'true'
run: |
cd meteor
NODE_OPTIONS="--max-old-space-size=4096" METEOR_DEBUG_BUILD=1 meteor build --allow-superuser --directory .
mv bundle/programs/web.browser/assets/ bundle/programs/web.browser/app/assets/ || true

- name: Meteor Bundle NPM Build
if: steps.check-build-and-push.outputs.enable == 'true'
run: |
Expand Down Expand Up @@ -426,9 +433,11 @@ jobs:
- mos-gateway
- corelib
- shared-lib
- meteor-lib
- job-worker
- openapi
- live-status-gateway
- webui

steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -471,29 +480,30 @@ jobs:
- blueprints-integration
- server-core-integration
- shared-lib
node-version: [14.x, 16.x, 18.x, 20.x]
- openapi
node-version: [22.x]
include:
# include additional configs, to run certain packages only for a certain version of node
- node-version: 14.x
- node-version: 22.x
package-name: corelib
send-coverage: true
- node-version: 14.x
- node-version: 22.x
package-name: job-worker
send-coverage: true
# manual openapi to avoid testing for 14.x
- node-version: 16.x
package-name: openapi
- node-version: 18.x
package-name: openapi
- node-version: 20.x
package-name: openapi
# No tests for the gateways yet
# - node-version: 18.x
# - node-version: 22.x
# package-name: playout-gateway
# - node-version: 18.x
# - node-version: 22.x
# package-name: mos-gateway
- node-version: 18.x
- node-version: 22.x
package-name: live-status-gateway
send-coverage: true
- node-version: 22.x
package-name: webui
# manual meteor-lib as it only needs a couple of versions
- node-version: 22.x
package-name: meteor-lib
send-coverage: true

steps:
- uses: actions/checkout@v4
Expand All @@ -513,7 +523,7 @@ jobs:
run: |
cd packages
yarn config set cacheFolder /home/runner/test-packages-cache
node is_node_14.js && yarn lerna run --ignore openapi install || yarn install
yarn install
yarn lerna run --scope \*\*/${{ matrix.package-name }} --include-dependencies --stream build
env:
CI: true
Expand All @@ -524,8 +534,8 @@ jobs:
env:
CI: true
- name: Send coverage
if: (matrix.node-version == '16.x' || matrix.send-coverage == true) && ((github.event_name == 'pull_request') && ((!startsWith(github.head_ref, 'release'))) || ((github.event_name == 'push') && (!startsWith(github.ref_name, 'release'))))
uses: codecov/codecov-action@v5
if: (matrix.node-version == '18.x' || matrix.send-coverage == true) && ((github.event_name == 'pull_request') && ((!startsWith(github.head_ref, 'release'))) || ((github.event_name == 'push') && (!startsWith(github.ref_name, 'release'))))
uses: codecov/codecov-action@v4
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

Expand Down Expand Up @@ -748,6 +758,6 @@ jobs:
CI: true
- name: Run check
run: |
node scripts/checkForMultipleVersions.mjs
yarn validate:versions
env:
CI: true
2 changes: 1 addition & 1 deletion .github/workflows/prerelease-libs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ jobs:
- blueprints-integration
- server-core-integration
- shared-lib
node-version: [14.x, 16.x, 18.x, 20.x]
node-version: [22.x]

steps:
- uses: actions/checkout@v4
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ meteor/.coverage/
node_modules
**/yarn-error.log
scratch/
meteor-settings.json

# Exclude JetBrains IDE specific files
.idea
Expand Down
2 changes: 1 addition & 1 deletion .node-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18.16
22.11
3 changes: 2 additions & 1 deletion .vscode/settings.json.default
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
"packages/shared-lib",
"packages/job-worker",
"packages/openapi",
"packages/live-status-gateway"
"packages/live-status-gateway",
"packages/webui"
],
"prettier.enable": true,
"sonarlint.connectedMode.project": { "projectKey": "nrkno_sofie-core" },
Expand Down
15 changes: 8 additions & 7 deletions DEVELOPER.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,8 @@ Follow these instructions to start up Sofie Core in development mode. (For produ

### Prerequisites

- Install [Node.js](https://nodejs.org) 14 (using [nvm](https://github.com/nvm-sh/nvm) or [nvm-windows](https://github.com/coreybutler/nvm-windows) is the recommended way to install Node.js)
- Install [Meteor](https://www.meteor.com/install) (`npm install --global meteor@2`)
- Install [Node.js](https://nodejs.org) 18 (using the same method you used above, you can uninstall node 14 if needed)
- Install an older version of corepack (`npm install --global corepack@0.15.3`)
- Install [Node.js](https://nodejs.org) 20 (using [nvm](https://github.com/nvm-sh/nvm) or [nvm-windows](https://github.com/coreybutler/nvm-windows) is the recommended way to install Node.js)
- Install [Meteor](https://www.meteor.com/install) (`npm install --global meteor`)
- Enable [corepack](https://nodejs.org/api/corepack.html#corepack) (`corepack enable`) as administrator/root. If `corepack` is not found, you may need to install it first with `npm install --global corepack`

- If on Windows, you may need to `npm install --global windows-build-tools` but this is not always necessary
Expand All @@ -31,11 +29,14 @@ Follow these instructions to start up Sofie Core in development mode. (For produ
```bash
git clone -b master https://github.com/nrkno/sofie-core.git
cd sofie-core
yarn
yarn start
```

> 💡 First startup may take a while, especially on Windows. To speed things up, consider adding `%LOCALAPPDATA%\.meteor` and the directory where you cloned `server-core` to your Windows Defender virus protection exclusions.

The Sofie ui (served by Vite) can be accessed at `http://localhost:3005`. The meteor http server can be access directly at `http://localhost:3000`

### Slightly more Involved Start

1. Clone the repository (for development, it is recommended to base your work on the latest unstable release branch)
Expand Down Expand Up @@ -136,13 +137,13 @@ Then submit this as a PR.

### ConfigManifests

The ConfigManifests for Blueprints and Gateways was replaced with JSONSchema in R50.
The ConfigManifests for Blueprints and Gateways was replaced with JSONSchema in R50.
However, one usage by AdlibActions for their userDataManifest remains as this is not something we are actively using.

## Blueprint Migrations

In R49, a replacement flow was added consisting of `validateConfig` and `applyConfig`.
It is no longer recommended to use the old migrations flow for showstyle and studio blueprints.
In R52, the replacement flow of `validateConfig` and `applyConfig` was extended to the system blueprint
It is no longer recommended to use the old migrations flow for system blueprints.

### ExpectedMediaItems

Expand Down
1 change: 0 additions & 1 deletion meteor/.eslintignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
.meteor
public
eslint-rules
scripts
server/_force_restart.js
/packages/
32 changes: 4 additions & 28 deletions meteor/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const tmpRules = {
}

const tsBase = {
extends: [...tsExtends, 'plugin:custom-rules/all'],
extends: [...tsExtends],
plugins: tsPlugins,
...tsParser,
settings: {
Expand Down Expand Up @@ -50,49 +50,25 @@ const tsBase = {
allowModules: ['meteor', 'mongodb'],
},
],
'jest/no-standalone-expect': 'off', // testInFiber confuses the rule
...tmpRules,
},
}

module.exports = {
extends: [...commonExtends, 'plugin:react/recommended'],
plugins: [...commonPlugins, 'react'],
extends: [...commonExtends],
plugins: [...commonPlugins],
rules: {
'prettier/prettier': 'error',
},
env: { es2017: true },
parserOptions: { sourceType: 'module', ecmaVersion: 2018 },
settings: {
react: {
version: 'detect', // Tells eslint-plugin-react to automatically detect the version of React to use
},
},
settings: {},
overrides: [
// Note: these replace the values defined above, so make sure to extend them if they are needed
{
files: ['*.ts'],
...tsBase,
},
{
files: ['*.tsx'],
...tsBase,
extends: [...tsBase.extends, 'plugin:react/recommended'],
parserOptions: {
...tsBase.parserOptions,
ecmaFeatures: {
jsx: true, // Allows for the parsing of JSX
},
},
rules: {
...tsBase.rules,
'node/no-extraneous-import': 'off', // because there are a lot of them as dev-dependencies
'node/no-missing-import': 'off', // erroring on every single import
'react/prop-types': 'off', // we don't use this
'@typescript-eslint/no-empty-interface': 'off', // many prop/state types are {}
'@typescript-eslint/promise-function-async': 'off', // event handlers can't be async
},
},
{
files: ['*.js'],
env: {
Expand Down
1 change: 1 addition & 0 deletions meteor/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ src/**/*.js.map
coverage
settings.json
server/_force_restart.js
public/

# Ignore TV2-features:
client/styles/tv2
Expand Down
36 changes: 11 additions & 25 deletions meteor/.meteor/packages
Original file line number Diff line number Diff line change
Expand Up @@ -8,29 +8,15 @@

# but you can also edit it by hand.

meteor-base@1.5.1 # Packages every Meteor app needs to have
mobile-experience@1.1.0 # Packages for a great mobile UX
mongo@1.16.7 # The database Meteor supports right now
reactive-var@1.0.12 # Reactive variable for tracker

standard-minifier-css@1.9.2 # CSS minifier run for production mode
standard-minifier-js@2.8.1 # JS minifier run for production mode
es5-shim@4.8.0 # ECMAScript 5 compatibility for older browsers
ecmascript@0.16.7 # Enable ECMAScript2015+ syntax in app code
typescript@4.9.4 # Enable TypeScript syntax in .ts and .tsx modules
shell-server@0.5.0 # Server-side component of the `meteor shell` command
modern-browsers@0.1.9 # Select when to allow use of the "modern" bundle

static-html@1.3.2 # Define static page content in .html files
react-meteor-data # React higher-order component for reactively tracking Meteor data

tracker@1.3.2 # Meteor's client-side reactive programming library
session@1.2.1
fourseven:scss

dynamic-import@0.7.3
ostrio:meteor-root
accounts-password@2.3.4

julusian:meteor-elastic-apm@2.5.2
meteor@2.0.1
webapp@2.0.3
ddp@1.4.2

mongo@2.0.2 # The database Meteor supports right now

ecmascript@0.16.9 # Enable ECMAScript2015+ syntax in app code
typescript@5.4.3 # Enable TypeScript syntax in .ts and .tsx modules

tracker@1.3.4 # Meteor's client-side reactive programming library

zodern:types
2 changes: 1 addition & 1 deletion meteor/.meteor/release
Original file line number Diff line number Diff line change
@@ -1 +1 @@
METEOR@2.13.3
METEOR@3.1
Loading
Loading