usb: fixes for USB device support #2971
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…FS devices With the commit fe3c001 ("usb: device_next: disable high-speed USB device descriptor if not used") there is no high-speed device descriptor by default. Signed-off-by: Johann Fischer <johann.fischer@nordicsemi.no> (cherry picked from commit 569f4d6d182e9802b3db9fc4ae58ec33f64e10e1)
In both implementation, when comparing received data length take into account that the buffer obtained from bt_buf_get_tx() stores the type at the top. The buffer types are H:4 and in the TX path we need to check for BT_HCI_H4_* types not BT_BUF_*. In the legacy implementation, the hci_acl_pkt_len() function obtains the length from the USB transaction buffer, which does not contain a buffer type at the top. In the new implementation, partially revert the changes and restore hci_pkt_get_len(), this will be required for any further changes anyway. Fixes commit f85d63a ("Bluetooth: Remove USB H4 mode support"). Signed-off-by: Johann Fischer <johann.fischer@nordicsemi.no> (cherry picked from commit 96422f262ed8cdcd4792a239d3ad6938831f67db)
…nsfer enqueue fail Do not take semaphore if transfer enqueue fails. Signed-off-by: Johann Fischer <johann.fischer@nordicsemi.no> (cherry picked from commit d2e42c99ac8090502125365b7eca45d002af27da)
…ng descriptor The intention was to use the "interface-name" string property in the interface string descriptor, but using the label property is acceptable again. Therefore, allow the use of the DT label property string in the interface string descriptor. Follow exactly the same approach as in the CDC ACM implementation introduced in the commit b079140 ("usb: device_next: cdc_acm: allow setting the interface description"). Signed-off-by: Johann Fischer <johann.fischer@nordicsemi.no> (cherry picked from commit 79a8073)
|
gchwier
approved these changes
Jun 23, 2025
Frodevan
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for USB device support.